Bug 65614

Summary:	Missing handle-name in RoomList
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	idle	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/xclaesse/telepathy-idle.git/log/?h=room-list
Whiteboard:
i915 platform:		i915 features:

Description Xavier Claessens 2013-06-10 15:37:02 UTC

The spec does not tell it explicitly, but I think that property is mandatory. And empathy actually crash if it is missing: https://bugzilla.gnome.org/show_bug.cgi?id=698742

Comment 1 Xavier Claessens 2013-06-10 15:41:50 UTC

Fix: http://cgit.collabora.com/git/user/xclaesse/telepathy-idle.git/log/?h=room-list

Comment 2 Simon McVittie 2013-06-10 15:52:47 UTC

Please test for this in tests/twisted/channels/room-list-channel.py.

Comment 3 Simon McVittie 2013-06-10 15:59:11 UTC

I'd also appreciate a spec change making handle-name, if not mandatory, then at least very strongly recommended.

Comment 4 Xavier Claessens 2013-06-11 10:02:15 UTC

idle branch updated with a unit test.

Spec branch:
http://cgit.collabora.com/git/user/xclaesse/telepathy-spec.git/log/?h=room-list

Comment 5 Simon McVittie 2013-06-11 10:06:57 UTC

r+ for both branches, thanks

Comment 6 Xavier Claessens 2013-06-11 12:01:44 UTC

Merged. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.