Bug 65659

Summary:	build-sys: don't install quotaon.service twice
Product:	systemd	Reporter:	Ross Burton <ross>
Component:	general	Assignee:	systemd-bugs
Status:	RESOLVED FIXED	QA Contact:	systemd-bugs
Severity:	normal
Priority:	medium	CC:	ross
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch

Description Ross Burton 2013-06-11 16:26:29 UTC

quotaon.service is already installed through dist_systemunit_DATA, so it doesn't
need to be added to nodist_systemunit_DATA.  Installing the same file twice
results in a race condition where the install process can fail.

Comment 1 Ross Burton 2013-06-11 16:28:38 UTC

Created attachment 80705 [details] [review]
Patch

Yes, we did actually hit this race.  In a release-candidate build too!

Comment 2 Zbigniew Jedrzejewski-Szmek 2013-06-12 05:42:33 UTC

Applied in http://cgit.freedesktop.org/systemd/systemd/commit/?id=3c527fd1. Thanks.

(The file is generated, so it should be on the nodist_ list, not dist_.)

Comment 3 Ross Burton 2013-06-12 06:23:20 UTC

I suddenly realised that it's probably generated whilst I was trying to get to sleep last night, but by the time I woke up you'd already dealt with the bug. :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.