Summary: | Support toggle translation | ||
---|---|---|---|
Product: | UIM | Reporter: | Shun-ichi TAHARA <jado> |
Component: | IM: Other IMs | Assignee: | uim-bugs |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | high | ||
Version: | unspecified | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 6089 | ||
Attachments: |
Proposed patch
Proposed patch (revised) Proposed patch (revised again) |
Description
Shun-ichi TAHARA
2006-04-15 23:08:17 UTC
Created attachment 5320 [details] [review] Proposed patch The feature seems useful. Thank you for the patch. But I think that the word 'toggle' is inappropriate to name the feature since I recognizes the verb as "switch to OPPOSITE state". Although I know that Japanese mobile phone users call the rotating character input method 'toggle', I believe that it's an Engrish. So I would like to replace the word with another if the word is not so strong de facto standard name for IME users. How about calling it 'rotate'? Oxford English Dictionary: n. 1 a device for fastening (esp. a garment), consisting of a crosspiece which can pass through a hole or loop in one position but not in another v.tr. provide or fasten with a toggle. Oxford English Etymology: (originally nautical) device, e.g. a pin, to hold a thing in place. 18th century of unknown origin. The Jargon File: vt. To change a bit from whatever state it is in to the other state; to change from 1 to 0 or from 0 to 1. This comes from 'toggle switches', such as standard light switches, though the word 'toggle' actually refers to the mechanism that keeps the switch in the position to which it is flipped rather than to the fact that the switch has two positions. 'Rotate' sounds good since it can transpose circulately around three or more types, such as hiragana -> katakana -> hankana. Now I changed some variable names and added the same feature on mana. Created attachment 5545 [details] [review] Proposed patch (revised) Thank you for the change. Etsushi, please review and commit the patch to trunk. OK. Will try later. Created attachment 5547 [details] [review] Proposed patch (revised again) OOPS, I have a mistake on patch-5545, use this one please. I've checked the patch for anthy.scm, and committed with some modification on small piece of the code with not r5rs conformation. In addition I put the code to begin conversion and cancel conversion in the transposing state. Also use reverse color for the transposing text. I'll do same for canna.scm and mana.scm later. Done for canna and mana in r3363. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.