| Summary: | [PATCH] Typo in cmake: DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Chengwei Yang <chengwei.yang.cn> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | chengwei.yang.cn |
| Version: | 1.5 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
[PATCH] Fix a typo for cmake: DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT
[PATCH 1/2] cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT [PATCH 2/2] cmake: remove a duplicate line and fix coding style [PATCH v2 1/4] cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT [PATCH v2 2/4] cmake: remove a duplicate line and fix coding style |
||
|
Description
Chengwei Yang
2013-06-25 05:33:22 UTC
Created attachment 81383 [details] [review] [PATCH] Fix a typo for cmake: DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT Created attachment 81384 [details] [review] [PATCH 1/2] cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT Created attachment 81385 [details] [review] [PATCH 2/2] cmake: remove a duplicate line and fix coding style Created attachment 81390 [details] [review] [PATCH v2 1/4] cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT Created attachment 81391 [details] [review] [PATCH v2 2/4] cmake: remove a duplicate line and fix coding style Hi Simon, I build patches for #bug 65990 based on these changes, so you can find 3/4, 4/4 there. A little ugly but just want to help you to do merge without any conflict. Comment on attachment 81390 [details] [review] [PATCH v2 1/4] cmake: fix a typo DBUS_DISABLE_ASSERTS should be DBUS_DISABLE_ASSERT Review of attachment 81390 [details] [review]: ----------------------------------------------------------------- Looks good. Comment on attachment 81391 [details] [review] [PATCH v2 2/4] cmake: remove a duplicate line and fix coding style Review of attachment 81391 [details] [review]: ----------------------------------------------------------------- Sure. Fixed in git for 1.7.6, thanks Could this fix be merged to the 1.6.x branch? |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.