Bug 66178

Summary:	add rfkill button keymap for HP EliteBook 2570p
Product:	systemd	Reporter:	Christoph Junghans <ottxor>
Component:	general	Assignee:	systemd-bugs
Status:	RESOLVED FIXED	QA Contact:	systemd-bugs
Severity:	normal
Priority:	medium	CC:	lennart, martin.pitt
Version:	unspecified
Hardware:	Other
OS:	All
URL:	https://github.com/systemd/systemd/pull/3
Whiteboard:
i915 platform:		i915 features:
Attachments:	add key map for 0xF8 add 0xF8 to hwdb

Description Christoph Junghans 2013-06-25 23:03:57 UTC

Created attachment 81433 [details] [review]
add key map for 0xF8

The EliteBook 2570p has a rfkill button (0xF8), which is currently not mapped.

Comment 1 Zbigniew Jedrzejewski-Szmek 2013-08-05 03:02:56 UTC

We need to add an entry to 60-keyboard.hwdb, and we need to know DMI vendor and DMI product. You can either modify the file yourself using existing contents as example, or please post 'udevadm info' for the keyboard input device here.

(After modifying /usr/lib/udev/hwdb.d/60-keyboard.hwdb, 'udevadm --debug hwdb --update' should be run to generate the binary database and a reboot should be performed to use the new settings.)

Comment 2 Christoph Junghans 2013-08-05 16:51:03 UTC

$ grep -i 0xf8 /var/log/messages
kernel: atkbd serio0: Unknown key pressed (translated set 2, code 0xf8 on isa0060/serio0).

$ udevadm info --query=property --name=/dev/input/event4
P: /devices/platform/i8042/serio0/input/input4/event4
N: input/event4
S: input/by-path/platform-i8042-serio-0-event-kbd
E: DEVLINKS=/dev/input/by-path/platform-i8042-serio-0-event-kbd
E: DEVNAME=/dev/input/event4
E: DEVPATH=/devices/platform/i8042/serio0/input/input4/event4
E: DMI_VENDOR=Hewlett-Packard
E: ID_INPUT=1
E: ID_INPUT_KEY=1
E: ID_INPUT_KEYBOARD=1
E: ID_PATH=platform-i8042-serio-0
E: ID_PATH_TAG=platform-i8042-serio-0
E: ID_SERIAL=noserial
E: MAJOR=13
E: MINOR=68
E: SUBSYSTEM=input
E: USEC_INITIALIZED=38052

So it should be something like:
keyboard:dmi:bvn*:bvr*:bd*:svnHewlett-Packard:pn*:pvr*
KEYBOARD_KEY_f8=rfkill

Right? How do I get the Product name?

Comment 3 Christoph Junghans 2013-08-06 01:59:48 UTC

Created attachment 83686 [details] [review]
add 0xF8 to hwdb

"dmidecode -s system-product-name" told me what I needed to know.

Comment 4 Zbigniew Jedrzejewski-Szmek 2013-08-07 03:06:46 UTC

Was never closed...

Comment 5 Zbigniew Jedrzejewski-Szmek 2013-08-07 03:17:32 UTC

Pushed in http://cgit.freedesktop.org/systemd/systemd/commit/?id=4a792f4.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.