Bug 66238

Summary:	dnotify backend is broken since Jan 2010
Product:	dbus	Reporter:	Chengwei Yang <chengwei.yang.cn>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	medium
Version:	1.5
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Chengwei Yang 2013-06-27 07:01:58 UTC

I just found that dnotify backend is broken since Jan 2010 with this change

commit 8a9880ffd2b81df38bb0e3492bda7a9636ac0280
Author: Colin Walters <walters@verbum.org>
Date:   Thu Jan 28 16:26:39 2010 -0500

    Clean up inotify watch handling
    
    Substantially based on a patch by Matthias Clasen <mclasen@redhat.com>
    kqueue implementation by Joe Marcus Clarke <marcus@freebsd.org>
    
    Previously, when we detected a configuration change (which included
    the set of config directories to monitor for changes), we would
    simply drop all watches, then readd them.
    
    The problem with this is that it introduced a race condition where
    we might not be watching one of the config directories for changes.
    
    Rather than dropping and readding, change the OS-dependent monitoring
    API to simply take a new set of directories to monitor.  Implicit
    in this is that the OS-specific layer needs to keep track of the
    previously monitored set.

Which changed the interface between the bus and the watch backend.

Should we fix it or drop it?

Comment 1 Simon McVittie 2013-06-27 10:33:34 UTC

(In reply to comment #0)
> I just found that dnotify backend is broken since Jan 2010

That's Bug #33001, I think.

*** This bug has been marked as a duplicate of bug 33001 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.