Bug 66337

Summary: evergreen_compute.c:559:26: error: 'kernel' undeclared (first use in this function) shader->active_kernel = kernel;
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Drivers/Gallium/r600Assignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: medium CC: ldexin, tstellar
Version: gitKeywords: regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2013-06-28 17:42:00 UTC
mesa: bee49cb0ecbacb9fbc9dddc5e560874adacc518e (master)

$ make
[...]
  CC	   evergreen_compute.lo
evergreen_compute.c: In function 'evergreen_launch_grid':
evergreen_compute.c:559:2: error: 'shader' undeclared (first use in this function)
  shader->active_kernel = kernel;
  ^
evergreen_compute.c:559:2: note: each undeclared identifier is reported only once for each function it appears in
evergreen_compute.c:559:26: error: 'kernel' undeclared (first use in this function)
  shader->active_kernel = kernel;
                          ^
gmake[3]: *** [evergreen_compute.lo] Error 1


2840bec56f79347b95dec5458b20d4a46d1aa445 is the first bad commit
commit 2840bec56f79347b95dec5458b20d4a46d1aa445
Author: Tom Stellard <thomas.stellard@amd.com>
Date:   Wed Jun 12 14:38:59 2013 -0700

    r600g/compute: Accept LDS size from the LLVM backend

    And allocate the correct amount before dispatching the kernel.

    Tested-by: Aaron Watry <awatry@gmail.com>

:040000 040000 ba0cd9cb41e0e221dd98beb00d24839f6ff41ac8 de853158383dd5f5349af59$
bisect run success
Comment 1 Vinson Lee 2013-07-01 04:06:58 UTC
Fixed by 47e35eff9dec8666efd70ffd08e4b03f83215026.

commit 47e35eff9dec8666efd70ffd08e4b03f83215026
Author: Tom Stellard <thomas.stellard@amd.com>
Date:   Fri Jun 28 11:08:07 2013 -0700

    r600g: Fix build
    
    Broken since 2840bec56f79347b95dec5458b20d4a46d1aa445 when opencl is
    disabled.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.