Bug 6648

Summary:	Solaris compiler warning: implicit function declaration: fcntl
Product:	XCB	Reporter:	Alan Coopersmith <alan.coopersmith>
Component:	Library	Assignee:	Jamey Sharp <jamey>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:

Description Alan Coopersmith 2006-04-19 12:31:21 UTC

Building the current sources from git on Solaris gets a warning of:
"xcb_conn.c", line 43: warning: implicit function declaration: fcntl

This is because xcb_conn.c includes <sys/fcntl.h> instead of the POSIX-standard
<fcntl.h> - the fix is simply:

--- a/xcb/src/xcb_conn.c
+++ b/xcb/src/xcb_conn.c
@@ -32,7 +32,7 @@
 #include <stdlib.h>
 #include <netinet/in.h>
 #include <sys/select.h>
-#include <sys/fcntl.h>
+#include <fcntl.h>
 #include <errno.h>

 #include "xcb.h"

Comment 1 Jamey Sharp 2006-04-20 14:52:57 UTC

Thanks Alan! I've committed and pushed your patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.