Bug 66656

Summary: intel-gpu-tools: manpages installed for missing tools
Product: xorg Reporter: "FeRD" (Frank Dana) <ferdnyc>
Component: App/otherAssignee: Daniel Vetter <daniel>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: minor    
Priority: medium    
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Possible fix to support noinst man pages none

Description "FeRD" (Frank Dana) 2013-07-07 01:59:18 UTC 
The Makefiles for intel-gpu-tools install man pages for a few tools which are themselves not installed by the default build, leading to there being man pages on the system for nonexistent commands.

tools/Makefile.am in the current git tree contains the following:

noinst_PROGRAMS = 			\
	intel_dump_decode 		\
	intel_infoframes		\
	intel_lid			\
	intel_panel_fitter

man/Makefile.am, however, includes:

appman_PRE = 				\
	intel_audio_dump.man		\
	intel_bios_dumper.man		\
	intel_bios_reader.man		\
	intel_error_decode.man		\
	intel_gpu_top.man		\
	intel_gtt.man			\
	intel_infoframes.man		\
	intel_lid.man			\
	intel_panel_fitter.man		\
	intel_reg_dumper.man		\
	intel_reg_read.man		\
	intel_reg_write.man		\
	intel_stepping.man		\
	intel_upload_blit_large.man	\
	intel_upload_blit_large_gtt.man \
	intel_upload_blit_large_map.man \
	intel_upload_blit_small.man

Perhaps the _infoframes, _lid, and _panel_fitter man pages should be masked out until their corresponding tools are part of the installation?


Note: This was originally reported against the Fedora intel-gpu-tools package as RHBZ#888930. https://bugzilla.redhat.com/show_bug.cgi?id=888930
Comment 1 "FeRD" (Frank Dana) 2013-07-07 02:13:22 UTC 
Created attachment 82131 [details] [review]
Possible fix to support noinst man pages

The attached (only slightly hideous) patch to man/Makefile.am appears, in my testing, to do the right thing for the no-install man pages during 'make', 'make install', 'make dist', and 'make clean'.
Comment 2 Daniel Vetter 2013-07-13 09:56:12 UTC 
I think we should simply add the the three additional apps to the install list.
Comment 3 "FeRD" (Frank Dana) 2013-07-18 23:23:19 UTC 
That would certainly address the issue. I was laboring under the (admittedly-unfounded) assumption that they were disabled for a reason. I suppose the question is, do they... work?
Comment 4 Daniel Vetter 2014-01-17 06:46:36 UTC 
commit e07e758004ae3014504b7799cff3838f11dce848
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Jan 17 07:42:22 2014 +0100

    tools: Install them all

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.