Summary: | Can't select other fill than color in Writer --> Drawing functions | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Florian Reisinger <reisi007> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | QA Contact: | Jorendc <jorendc> |
Severity: | major | ||
Priority: | high | CC: | jmadero.dev, mst.fdo, samuel_wolf, vmiklos |
Version: | 4.1.0.2 rc | Keywords: | regression |
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | target:4.2.0 target:4.1.1 | ||
i915 platform: | i915 features: |
Description
Florian Reisinger
2013-07-11 16:10:20 UTC
I can confirm this behavior tested using Mac OSX 10.8.4 with LibreOffice 4.1.0.2 RC How to reproduce: * Open Writer * View > Toolbars > Drawing * Draw rectangle in modus 'color' * Deselect rectangle Behavior: modus is still 'color'. _same as in Draw_ * Change modus to 'hatching' for example * Draw again a rectangle Behavior: no hatching is drawn, just a regular rectangle as with modus 'color'. _same as in Draw_ * deselect rectangle * reselect it Behavior: modus is reseted to 'color'. _Modus in Draw is still 'hatching' (but no hatching is applied too)_ So, looks to me also a draw issue? Kind regards, Joren Hi Joren, In my master Draw is working... Reproduced "Ubuntu rc3" and "Win rc2". Can confirm this bug in LO Version: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 The "Drawing Object Properties" Toolbar do not work as expected. "right click" -> "Area..." on the circle to set color "none" work as expected. OS Debian 7.1 amd64 Use the new sidebar (experimental feature) work. regression from: commit d884f8f65cc73cf932cde1e40cadf13556a7d44e Author: Miklos Vajna <vmiklos@suse.cz> AuthorDate: Tue Feb 12 16:14:23 2013 +0100 SwFrmDlg: initial gradient background UI specifically the 2 changed entries in bastyp/init.cxx apparently have some side effect... so what happens for this drawing toolbar is that a "uno:.FillStyle" is dispatched, which is turned into WhichId SID_ATTR_FILL_STYLE 10164 This causes an SfxItemSet with one item to arrive in SdrEditView::SetAttrToMarked and sdr::properties::AttributeProperties::ItemChanged, where in the old version the item is applied but not in the new version; the difference is the old one had WhichId 1014 XATTR_FILLSTYLE new one is 123 RES_FILL_STYLE, i.e. the added one. The different WhichIds come from TransformParameters calling sal_uInt16 nWhich = rSet.GetPool()->GetWhich(nSlotId); where previously the entry from the secondary pool created in XOutdevItemPool::XOutdevItemPool was returned but now we get the one from the primary (sw) pool instead. I'll take care of this. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f694f14ab64f48e40365fd877e201a0382297368 fdo#66827 sw: rename SID_ATTR_FILL_GRADIENT to SID_SW_ATTR_FILL_GRADIENT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=823cab696bdaa059e5d1243a636e7d975b2110cc&h=libreoffice-4-1 fdo#66827 sw: rename SID_ATTR_FILL_GRADIENT to SID_SW_ATTR_FILL_GRADIENT It will be available in LibreOffice 4.1.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed on master, backported to -4-1, so marking as resolved. Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-4-1-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1ba41e17fbf5039067b46df5c433a5811353d8b&h=libreoffice-4-1-1 fdo#66827 sw: rename SID_ATTR_FILL_GRADIENT to SID_SW_ATTR_FILL_GRADIENT It will be available already in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.