| Summary: | Private symbols exported | ||
|---|---|---|---|
| Product: | libmbim | Reporter: | Thomas Bechtold <thomasbechtold> |
| Component: | General | Assignee: | Aleksander Morgado <aleksander> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Patch. | ||
|
Description
Thomas Bechtold
2013-07-16 06:35:10 UTC
Those symbols are used by the unit testers when building the library, and won't be available in any of the installed header files. But I agree that we should not export them if possible. If you filter them out when building the final library (e.g. -export-symbols-regex '^mbim_.*'), will I be able to still use them for the unit tests? (In reply to comment #1) > Those symbols are used by the unit testers when building the library, and > won't be available in any of the installed header files. But I agree that we > should not export them if possible. > > If you filter them out when building the final library (e.g. > -export-symbols-regex '^mbim_.*'), will I be able to still use them for the > unit tests? No. Then you get: test_fragment-test-fragment.o: In function `test_fragment_receive_multiple': /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:119: undefined reference to `_mbim_message_fragment_collector_init' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:121: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:122: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:123: undefined reference to `_mbim_message_fragment_collector_complete' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:128: undefined reference to `_mbim_message_fragment_collector_add' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:130: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:131: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:132: undefined reference to `_mbim_message_fragment_collector_complete' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:136: undefined reference to `_mbim_message_fragment_collector_add' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:138: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:139: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:140: undefined reference to `_mbim_message_fragment_collector_complete' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:144: undefined reference to `_mbim_message_fragment_collector_add' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:146: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:147: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:148: undefined reference to `_mbim_message_fragment_collector_complete' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:149: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:150: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:154: undefined reference to `_mbim_message_fragment_get_payload' test_fragment-test-fragment.o: In function `test_fragment_receive_single': /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:46: undefined reference to `_mbim_message_is_fragment' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:47: undefined reference to `_mbim_message_fragment_get_total' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:48: undefined reference to `_mbim_message_fragment_get_current' /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:50: undefined reference to `_mbim_message_fragment_get_payload' test_fragment-test-fragment.o: In function `test_fragment_send_multiple_common': /home/tom/devel/libmbim/libmbim-glib/test/test-fragment.c:179: undefined reference to `_mbim_message_split_fragments' collect2: error: ld returned 1 exit status make[3]: *** [test-fragment] Error 1 make[3]: Leaving directory `/home/tom/devel/libmbim/libmbim-glib/test' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/tom/devel/libmbim/libmbim-glib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/tom/devel/libmbim' make: *** [all] Error 2 Ok, let me try to handle that in some other way. Created attachment 82470 [details] [review] Patch. Thomas, what do you think of the attached patch? (In reply to comment #4) > Created attachment 82470 [details] [review] [review] > Patch. > > Thomas, what do you think of the attached patch? Works for me. Great. Thanks! Pushed to git master now. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.