Bug 66994

Summary:	Documentation on scanning order of <servicedir> entries is wrong
Product:	dbus	Reporter:	Joseph Artsimovich <joseph.artsimovich>
Component:	core	Assignee:	Havoc Pennington <hp>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	chengwei.yang.cn
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review?
i915 platform:		i915 features:
Attachments:	[PATCH] Fix dbus-daemon document about servicedir

Description Joseph Artsimovich 2013-07-17 12:32:04 UTC

From dbus-daemon man page it follows that <servicedir> entries are scanned
in reverse order they appear in config file:
-----------------------
<servicedir>
Adds a directory to scan for .service files. Directories are scanned
starting with the last to appear
in the config file (the first .service file found that provides a
particular service will be used).
-----------------------

Unfortunately my tests show that <servicedir> entries are really scanned
in the order they appear in config file. I tested on 1.6.4 and 1.7.4.

I suggest documentation to be changed to:
-----------------------
<servicedir>
Adds a directory to scan for .service files. Directories appearing earlier in the config file have priority over those appearing later. If multiple .service files providing the same service appear in different directories specified with <servicedir>, the one from the directory of highest priority will be used.
-----------------------

Comment 1 Simon McVittie 2013-07-17 14:19:15 UTC

dbus/doc is not the component you think it is, for annoying historical reasons - reassigning to dbus/core. We should really get that fixed.

Comment 2 Ralf Habacker 2013-07-17 18:15:31 UTC

(In reply to comment #1)
> dbus/doc is not the component you think it is, for annoying historical
> reasons - reassigning to dbus/core. We should really get that fixed.

Any idea how to administrate this ? on https://bugs.freedesktop.org/describecomponents.cgi?product=dbus there is no way.

Comment 3 Simon McVittie 2013-07-18 09:37:21 UTC

(In reply to comment #2)
> Any idea how to administrate this ? on
> https://bugs.freedesktop.org/describecomponents.cgi?product=dbus there is no
> way.

I think we have to ask the fd.o sysadmins to change it. There are some other changes to fd.o bug tracking that I'd like to make (in particular, getting a security/maintainer contact address, and making Havoc not be the default assignee since he hasn't touched D-Bus for years) so I'll batch up requests and do them all at once.

Comment 4 Chengwei Yang 2013-09-04 06:56:15 UTC

Created attachment 85170 [details] [review]
[PATCH] Fix dbus-daemon document about servicedir

Comment 5 Simon McVittie 2013-09-13 14:01:10 UTC

Fixed in git for 1.7.6.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.