| Summary: |
TablesSupplier name clash when dots in schema/table name |
| Product: |
LibreOffice
|
Reporter: |
Lionel Elie Mamane <lionel> |
| Component: |
Database | Assignee: |
Not Assigned <libreoffice-bugs> |
| Status: |
NEW
---
|
QA Contact: |
|
| Severity: |
normal
|
|
|
| Priority: |
medium
|
CC: |
iplaw67, libreoffice
|
| Version: |
unspecified | |
|
| Hardware: |
All | |
|
| OS: |
All | |
|
| Whiteboard: |
EasyHack DifficultyInteresting SkillCpp SkillSQL |
|
i915 platform:
|
|
i915 features:
|
|
|---|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
The implementations of interface XTablesSupplier.getTables() in LibreOffice currently return a XNameAccess that uses: schemaName + "." + tableName as "name" to access the tables. However, this scheme can make collisions between schemaName == "foo" tableName == "bar.qux" and schemaName == "foo.bar" tableName == "qux" because in both cases, the name resolves to "foo.bar.qux". The XNameAccess should rather use properly quoted and escaped names, that is: '"' + escapeDoubleQuotes(schemaName) + '"."' + escapeDoubleQuotes(tableName) + '"' double quotes should be escaped by repeating them. At the same time, all callers to this interface have to be changed, too. The whole name construction business should be done by a utility function, most probably ::dbtools::composeTableNameForSelect (which needs to be changed to handle double quotes in names...). Implementations of XTablesSupplier: 1) MySQL driver: I haven't found where the name is constructed; possibly in db-agnostic dbaccess/ or connectivity/source/sdbcx or connectivity/source/commontools code. 2) PostgreSQL driver: pq_xtables.cxx function Tables::refresh code snippet: buf.append( schema ).appendAscii( "." ).append( name ); map[ buf.makeStringAndClear() ] = currentTableIndex; callers that need to be also modified: pq_resultsetmetadata.cxx function ResultSetMetaData::checkTable