Bug 67305

Summary:

[sna] Regression: Steam windows "empty"

Product:

xorg

Reporter:

Andreas Reis <andreas.reis>

Component:

Driver/intel

Assignee:

Chris Wilson <chris>

Status:

RESOLVED FIXED

QA Contact:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Severity:

normal

Priority:

medium

Version:

git

Hardware:

x86-64 (AMD64)

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Clip in blit rather than reject	none

Description Andreas Reis 2013-07-25 14:21:46 UTC

This might sound strange, but I've verified it repeatedly:

With the commit "sna/dri: Cleanup validation of blit extents" (6d80bd6a) applied all the windows created by Steam (my only lib32-gtk2 app) will not be painted. Haven't observed this with any other program yet.

They'll simply be empty (filled instead with content copied from other parts of the desktop, that is). Their functionality is uninfluenced, even the drop-down menus from the main window are displayed properly.

Tested also with the most recent commit applied (ef2a4573), same bug.

xorg-git, Arch Linux x64, Haswell 4770

Comment 1 Chris Wilson 2013-07-25 14:41:06 UTC

Created attachment 82999 [details] [review]
Clip in blit rather than reject

This is the patch I am currently testing. The root cause is fixed by https://bugs.freedesktop.org/attachment.cgi?id=81263

Comment 2 Chris Wilson 2013-07-25 19:13:10 UTC

commit 6f5fd772c7ca656b86394a0f036d4e0cf5b33d8e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Jul 25 08:29:55 2013 +0100

    sna/dri: Discard the strict checking for stale bo before performing a blit
    
    Instead of checking that the DRI2Buffers match up with the current
    DRI2Drawable, clip the area that is being copied to the minimum extents
    of the Drawable, source and destination buffers. This ensures that we
    never read nor write beyond the extents of the allocated or visible
    regions.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67210
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67305
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.