Bug 6766

Summary: Overrun local variable in PageLabelInfo::toRoman
Product: poppler Reporter: Kjartan Maraas <kmaraas>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: high    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: possible patch

Description Kjartan Maraas 2006-04-27 18:35:25 UTC
Coverity report #902
Comment 1 Kjartan Maraas 2006-04-27 18:36:09 UTC
Created attachment 5498 [details] [review]
possible patch

Could this be the right fix?
Comment 2 Kjartan Maraas 2006-04-29 04:11:47 UTC
s/runs/reports :-)
Comment 3 Albert Astals Cid 2006-04-30 01:58:12 UTC
Your patch is wrong, i've checked and the code works up to 3999, accessing the 
7th element of the uppercaseNumerals lowercaseNumerals arrays is NOT wrong 
because there's a \0 there.

I'm closign the bug because AFAIK 4000 can not be represented with the roman 
notation i learnt in school.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.