| Summary: | [PATCH] wayland-scanner.m4: Warn when wayland-scanner.pc not found | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | Dwayne Litzenberger <dlitz> |
| Component: | wayland | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch
The previous patch was broken. Use this one. |
||
Comment on attachment 83631 [details]
patch
Oops, this patch is broken. I'll send a fixed one.
Created attachment 83633 [details] [review] The previous patch was broken. Use this one. updated patch A PKG_CHECK_MODULES() call is now in wayland-scanner.m4, which based on the context in your patch looks like it was missing when you filed this bug. This should address the issue you reported. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 83631 [details] patch I got this mysterious build error when I tried to build Weston (from the git repo) for the first time: make[2]: *** No rule to make target `screenshooter-server-protocol.h', needed by `all'. Stop. The problem was that I had a typo in my $PKG_CONFIG_PATH, which caused the rules for generating %-server-protocol.h to be omitted from Weston's Makefile (since pkg-config couldn't the configure script where to look for wayland-scanner.m4). With this commit, we emit a warning from the configure script when wayland-scanner.pc can't be found, so that the above error (if it occurs) will seem less cryptic.