Bug 6786

This doesn't make sense to me; the QueryVersion code carefully bounds the
negotiated extension version to those supported by both client and server.

The reference to our bugtracker:
http://bugs.archlinux.org/task/4535

I run Xorg 7.1RC on my test system, so the update to fixesproto and libxfixes
looked good, but it wasn't when used with 7.0. The offended code is this piece:

static int
ProcXFixesDispatch (ClientPtr client)
{
    REQUEST(xXFixesReq);
    XFixesClientPtr pXFixesClient = GetXFixesClient (client);

    if (pXFixesClient->major_version >= NUM_VERSION_REQUESTS)
	return BadRequest;
    if (stuff->xfixesReqType > version_requests[pXFixesClient->major_version])
	return BadRequest;
    return (*ProcXFixesVector[stuff->xfixesReqType]) (client);
}

When a client with libxfixes 4.0 connects to a server which supports the XFIXES
3.x extension, it gets a BadRequest error all the time, no matter what function
gets called. The libxfixes library contains code to check if the server supports
a specific version of the extension, which looks right to me. When a program
uses libxfixes correctly, a libxfixes 4.0 client should be able to work with a
3.0 server without problems. This piece of code in the server however throws a
BadRequest to the client, no matter what call it does.

Jan is sitting next to me here on LinuxTag and it looks like we got it figured out: 
The commit time of the Porto version was ealier than the one of the server. He
happened to pick the proto and the server code right in between. 
The older server code of course builds well  with the newer proto code. The
problem is in the server however the server code does:

 if (stuff->majorVersion < XFIXES_MAJOR) {
        rep.majorVersion = stuff->majorVersion;
        rep.minorVersion = stuff->minorVersion;
    } else {
        rep.majorVersion = XFIXES_MAJOR;
        if (stuff->majorVersion == XFIXES_MAJOR &&
   ....
XFIXES_MAJOR comes from the proto.
In dispatch it does:
 if (pXFixesClient->major_version >= NUM_VERSION_REQUESTS)
        return BadRequest;
which will fail of course.
It sould be permissible to build a server with a newer version of the proto
headers (as long as existing calls have not been changed). However the server
should use it's own notion of the version - not one that it picks from the proto
headers. Furthermore a pkgconfig test should check if the proto headers are
older than the server version.
This is a glitch that is introduced with modularization,

Fixed in master and 1.2 branch, thanks!