Bug 67925

Summary:	ARB_vertex_array_bgra api-errors test fails when normalized is false
Product:	piglit	Reporter:	Ian Romanick <idr>
Component:	tests	Assignee:	Kenneth Graunke <kenneth>
Status:	RESOLVED FIXED	QA Contact:	Eric Anholt <eric>
Severity:	normal
Priority:	medium	CC:	corey, fredrik, idr, kenneth
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Ian Romanick 2013-08-08 23:32:34 UTC

There are two patches for this out on the list.  Sort it out and commit something. :)

http://lists.freedesktop.org/archives/mesa-dev/2013-July/041774.html
http://lists.freedesktop.org/archives/mesa-dev/2013-July/042487.html

Comment 1 Fredrik Höglund 2013-08-09 00:11:12 UTC

I have yet a third version in my arb-vertex-attrib-binding branch:

http://cgit.freedesktop.org/~fredrik/mesa/commit/?h=arb-vertex-attrib-binding&id=df98f9f8

Comment 2 Kenneth Graunke 2013-08-16 04:45:52 UTC

I picked Fredrik's version as I liked it best.  It's now pushed to master as:

commit 0e7a61a29f883c63a5439ac16edffffdeba3aaf4
Author: Fredrik Höglund <fredrik@kde.org>
Date:   Fri Apr 12 17:36:06 2013 +0200

    mesa: Update the BGRA vertex array error handling
    
    The error code was changed from INVALID_VALUE to INVALID_OPERATION
    in OpenGL 3.3. We should also generate an error when size is BGRA
    and normalized is FALSE.
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Since this uses INVALID_OPERATION, it remains to change the tests.  I've posted patches for this:
http://lists.freedesktop.org/archives/piglit/2013-August/006774.html
http://lists.freedesktop.org/archives/piglit/2013-August/006775.html

In the meantime, I've changed this bug to Piglit and removed it from the Mesa 9.2 release tracker bug (as it isn't a Mesa bug now).

Comment 3 Fabian Bieler 2017-12-18 23:34:33 UTC

The offending Piglit tests were fixed / removed by these two commits:

c2c0caab47559e43b8129cd423a75e3c0d46c556
Change INVALID_VALUE to INVALID_OPERATION in ARB_vertex_array_bgra test.

a05a9582ae0141b1b8ee21bf53bc7291ef2272f7
arb_vertex_array_bgra: Remove vertex-array-bgra.c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.