| Summary: | [SNB Bisected]Piglit shaders/glsl-fs-atan-3 fail | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | idr |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
lu hua
2013-08-14 01:44:40 UTC
Following webglc cases also fail with same bisect commit: conformance/canvas/drawingbuffer-hd-dpi-test.html conformance/glsl/functions/glsl-function-sign.html conformance/glsl/functions/glsl-function-step-float.html conformance/glsl/functions/glsl-function-step-gentype.html Can you try Ken's patch from the mesa-dev mailing list: http://lists.freedesktop.org/archives/mesa-dev/2013-August/043270.html (In reply to comment #2) > Can you try Ken's patch from the mesa-dev mailing list: > > http://lists.freedesktop.org/archives/mesa-dev/2013-August/043270.html Fixed by this patch. Fixed on master by: commit 90129da82c91b731c7c65e8e3adbde58d8c62840 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Tue Aug 13 16:07:56 2013 -0700 i965/fs: Fix Sandybridge regressions from SEL optimization. Sandybridge is the only platform that supports an IF instruction with an embedded comparison. In this case, we need to emit a CMP to go along with the SEL. Fixes regressions in Piglit's glsl-fs-atan-3, fs-unpackHalf2x16, fs-faceforward-float-float-float, isinf-and-isnan fs_basic, and isinf-and-isnan fs_fbo. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68086 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com> Tested-by: lu hua <huax.lu@intel.com> There is no need to backport this to 9.2, since the SEL optimization doesn't exist there. Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.