Bug 6812

Summary:	XCBProtocolRequest structure ought to have flags bitmask
Product:	XCB	Reporter:	Jamey Sharp <jamey>
Component:	Library	Assignee:	Jamey Sharp <jamey>
Status:	RESOLVED WONTFIX	QA Contact:	xcb mailing list dummy <xcb>
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Jamey Sharp 2006-05-02 06:26:03 UTC

Currently, XCBProtocolRequest has an isvoid flag. I expect more flags to become
useful later -- the current motivating example is a 'multiple replies' flag. So
isvoid should become a short or int bitmask. short is probably better so the
structure can be packed smaller, and 16 flags probably will suffice.

Comment 1 Jamey Sharp 2009-10-09 09:27:23 UTC

Replacing xcb_protocol_request_t.isvoid with a uint8_t "flags" bitmask would be ABI-compatible, as long as isvoid is the least-significant bit, but it would need a bit of care to stay API-compatible. This may still be worth doing.

Comment 2 Bart Massey 2009-10-09 13:59:22 UTC

I don't think there's any point until we actually want a second flag, at which point yes, it's fine.

Comment 3 Daniel Stone 2019-02-16 12:57:04 UTC

If we haven't needed one until now, we presumably never will.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.