Bug 68143

Summary:	Work around empty aliases in roster updates from Facebook
Product:	Telepathy	Reporter:	Alban Browaeys <prahal>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED WONTFIX	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	christian
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review-, should be conditional on Facebook
i915 platform:		i915 features:
Attachments:	Do not update when we receive empty nodes from wocky.

Description Alban Browaeys 2013-08-15 11:26:38 UTC

Created attachment 84096 [details] [review]
Do not update when we receive empty nodes from wocky.

Facebook send empty "updates" around one minute after initial
grab. This ends up updating the cache with empty name and photo
which leaves the roster with only the facebook id.

This patch is kind of a hack. I did not investigate extensively why I get such near empty update from facebook though. Hope it will help bring the issue closer to completion.

Here I now have stable names and photos in empathy (otherwise after around one minutes they go away and it is hard to guess from facebook id (<number@facebook.com>) who is online.

Comment 1 Simon McVittie 2013-08-19 10:27:17 UTC

Comment on attachment 84096 [details] [review]
Do not update when we receive empty nodes from wocky.

Review of attachment 84096 [details] [review]:
-----------------------------------------------------------------

I think this breaks the case of a contact genuinely changing their avatar to "nothing", or of another resource on our account changing our name for a contact to "" (which makes very little sense, but is at least well-defined).

If we're only doing this as a workaround for Facebook's sort-of-XMPP server, we should make it conditional on the server being Facebook.

Comment 2 Simon McVittie 2013-09-08 09:13:18 UTC

I'll try to look at this myself on Monday.

Comment 3 George Kiagiadakis 2016-07-13 10:19:07 UTC

Afaik, facebook no longer supports XMPP, so I'm closing this report.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.