Bug 68402

Created attachment 84413 [details]
screenshot

Thanks for the bisect Ján

Bit short on hardware atm, so can you confirm hunk of the commit causes the issue? I'm suspecting the last one, although there is a small chance that it's the second to last.

Cheers
Emil

It's the last hunk that causes the issue:

BEGIN_NVC0(push, NVC0_3D(VIEWPORT_HORIZ(0)), 2);
PUSH_DATA (push, nvc0->framebuffer.width << 16);
PUSH_DATA (push, nvc0->framebuffer.height << 16);

Removing it solved the issue, so I tried to do the same thing in current(master) code.
After removing 2 of these hunks (there is another one in commit 443b247878edd6a67adc073b0c36e2941436b9a0), the bug is not present.

I have no idea what I've broken in the process, though. :-)

-Ján

You're a star Ján

Just had a word with our main dev and he suggested that
viewport transformation is optional, whereas viewport clip rectangle must be set before and after 3d_blit().

With that said, here is what can be done to double-check/fix this - note a quick piglit [1] test before and after each one, plus testing of other games/gl apps is essential.

* nuke the viewport clip rectangle (despite all odds)
* change the viewport clip rectangle - traceback and use the original values (the ones saved at the begingin on 3d_blit() and restored at the end)
* nuke the viewport transformation
* add the conditional NV50_TIC_5_LAST_LEVEL__MASK on tic[5] in nvc0_create_texture_view (compare vs nv50_create_texture_view)

I'm hoping that one of the last two will do the job, although chances are that it may be one of the first two. Either way a piglit and further testing will prove which solution is the most appropriate.

Feel free to give it a shot yourself, as it will take a some time until I get to it(apart from the lack of HW).

Note: depending on your luck(and other unknown to me factors) piglit may lockup X and your system. Normally a s2r cycle is sufficient to get it back into shape, otherwise a reboot is needed.

Cheers,
Emil

[1] http://cgit.freedesktop.org/piglit/

The issue should be resolved by commit ad4dc7723(nvc0: restore viewport after blit), which will make it's way into the next 9.1 and 9.2 mesa release.

Feel free to reopen if above commit does not resolve the issue.