Bug 6845

Summary: Regression from 6.8.2 when only TV output is in use [PATCH]
Product: xorg Reporter: Fabio Massimo Di Nitto <fabbione>
Component: Driver/nVidia (open)Assignee: Aaron Plattner <aplattner>
Status: RESOLVED INVALID QA Contact: Xorg Project Team <xorg-team>
Severity: major    
Priority: high Keywords: patch, regression
Version: 7.0.0   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Fabio Massimo Di Nitto 2006-05-06 03:08:35 UTC 
Matt Zimmerman reported a regression using NV11 card from 6.8.2 in 7.0.0 using
only the TV output.

See: https://launchpad.net/distros/ubuntu/+source/xserver-xorg-driver-nv/+bug/41934/
for card details.

The regression has been introduced with this commit:
https://bugs.freedesktop.org/show_bug.cgi?id=3095
https://bugs.freedesktop.org/attachment.cgi?id=2501

The new code introduced in nv_setup.c causes the full hang of the machine.

This workaround seems to fix the problem but of course i am more interested to
know if this is the right fix or not.

Thanks
Fabio

--- xserver-xorg-driver-nv-1.0.1.5.orig/src/nv_setup.c
+++ xserver-xorg-driver-nv-1.0.1.5/src/nv_setup.c
@@ -694,13 +694,15 @@
     if(!pNv->FlatPanel || (pScrn->depth != 24) || !pNv->twoHeads)
         pNv->FPDither = FALSE;
 
-    pNv->LVDS = FALSE;
-    if(pNv->FlatPanel && pNv->twoHeads) {
-        pNv->PRAMDAC0[0x08B0/4] = 0x00010004;
-        if(pNv->PRAMDAC0[0x08B4/4] & 1)
-           pNv->LVDS = TRUE;
-        xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Panel is %s\n", 
-                   pNv->LVDS ? "LVDS" : "TMDS");
+    if((pNv->Chipset & 0xffff) != 0x0110) {
+       pNv->LVDS = FALSE;
+       if(pNv->FlatPanel && pNv->twoHeads) {
+           pNv->PRAMDAC0[0x08B0/4] = 0x00010004;
+           if(pNv->PRAMDAC0[0x08B4/4] & 1)
+               pNv->LVDS = TRUE;
+           xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Panel is %s\n", 
+               pNv->LVDS ? "LVDS" : "TMDS");
+       }
     }
 }
Comment 1 Daniel Stone 2007-02-27 01:31:59 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Jesse Adkins 2010-11-14 23:18:55 UTC 
Can you redo this as a patch made by git format-patch? It's easier to apply and preserve ownership that way. Additionally, you may want to send this to nouveau@lists.freedesktop.org for review. They should be able to tell you if it's the right fix or not.
Comment 3 Fabio Massimo Di Nitto 2010-11-15 03:33:39 UTC 
(In reply to comment #2)
> Can you redo this as a patch made by git format-patch? It's easier to apply and
> preserve ownership that way. Additionally, you may want to send this to
> nouveau@lists.freedesktop.org for review. They should be able to tell you if
> it's the right fix or not.

I don´t have access to the hw anymore to test. So any patch rediff would be a blind fix. Too bad developers waited 4 years to give it a check.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.