Bug 68541

Summary:	Should probably look for ntp-unit.d under rootprefix
Product:	systemd	Reporter:	Sjoerd Simons <sjoerd>
Component:	general	Assignee:	systemd-bugs
Status:	RESOLVED NOTABUG	QA Contact:	systemd-bugs
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	proposed patch

Description Sjoerd Simons 2013-08-25 19:04:43 UTC

timedated is hardcoded to look under /usr/lib/systemd/ntp-units.d for ntp units, this feels a bit odd, at last on debian where the rootprefix is / and as such e..g the systemd unit files are under /lib/systemd/system so one would expect ntp-units.d to be under /lib/systemd/ntp-unit.d

patch attached to change to that behaviour.

Comment 1 Sjoerd Simons 2013-08-25 19:05:13 UTC

Created attachment 84612 [details] [review]
proposed patch

Comment 2 Harald Hoyer 2013-08-30 08:21:15 UTC

Hmm, for other paths, I see this pattern:


                                    "/usr/lib/systemd/system-preset",
#ifdef HAVE_SPLIT_USR
                                    "/lib/systemd/system-preset",
#endif
                                    NULL);

Comment 3 Lennart Poettering 2013-09-12 17:08:43 UTC

Hmm, but why would we look for this in rootprefix? I mean, this is used by timedated only, which is definitely in prefix, not in rootprefix, so what's the point?

In general we should only look into prefix except where we need something during early boot in which case we should also look into rootprefix. But the ntp-unit.d thingy is clearly one of the cases where things are *not* required for early boot.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.