| Summary: | Simple EGL clients should not be compiled when configured with --disable-egl | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | U. Artie Eoff <ullysses.a.eoff> |
| Component: | weston | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | configure output | ||
commit edb6a3bd0a802eb3c9cb71e4d29588d69980c2b4 Author: Kristian Høgsberg <krh@bitplanet.net> Date: Tue Sep 3 22:59:17 2013 -0700 configure.ac: Only enable enable_simple_egl_clients if enable_egl is yes This simplifies a few checks and makes sure we only build the subsurfaces client if EGL is enabled. https://bugs.freedesktop.org/show_bug.cgi?id=68727 (In reply to comment #1) > commit edb6a3bd0a802eb3c9cb71e4d29588d69980c2b4 > Author: Kristian Høgsberg <krh@bitplanet.net> > Date: Tue Sep 3 22:59:17 2013 -0700 > > configure.ac: Only enable enable_simple_egl_clients if enable_egl is yes > > This simplifies a few checks and makes sure we only build the > subsurfaces client if EGL is enabled. > > https://bugs.freedesktop.org/show_bug.cgi?id=68727 This fixes it on master. But, it's still an issue on the 1.2 branch (current stable). Is it worthwhile to cherry-pick to 1.2? (In reply to comment #2) > (In reply to comment #1) > > commit edb6a3bd0a802eb3c9cb71e4d29588d69980c2b4 > > Author: Kristian Høgsberg <krh@bitplanet.net> > > Date: Tue Sep 3 22:59:17 2013 -0700 > > > > configure.ac: Only enable enable_simple_egl_clients if enable_egl is yes > > > > This simplifies a few checks and makes sure we only build the > > subsurfaces client if EGL is enabled. > > > > https://bugs.freedesktop.org/show_bug.cgi?id=68727 > > This fixes it on master. But, it's still an issue on the 1.2 branch > (current stable). Is it worthwhile to cherry-pick to 1.2? This issue can be worked around by adding '--disable-simple-egl-clients' to configure, also. Nonetheless, by itself, this patch is probably not critical enough to warrant another 1.2 minor release. Thus, it's probably best to say it's a "wontfix" for 1.2. Closing. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 84881 [details] configure output When Weston is configured with '--disable-egl' it still attempts to build the Simple EGL Clients (see attached configure output). This results in a failed compile/link step during make: CCLD weston-subsurfaces /usr/bin/ld: weston_subsurfaces-subsurfaces.o: undefined reference to symbol 'eglBindAPI' /usr/bin/ld: note: 'eglBindAPI' is defined in DSO /home/uartie/Work/wayland/install/lib/libEGL.so.1 so try adding it to the linker command line /home/uartie/Work/wayland/install/lib/libEGL.so.1: could not read symbols: Invalid operation collect2: error: ld returned 1 exit status make[3]: *** [weston-subsurfaces] Error 1 ---- weston (master) heads/master-0-ge1b655d weston (1.2) heads/1.2-0-g237c1c8