Bug 69054

Summary:	clear-color.c(112) : error C2057: expected constant expression
Product:	piglit	Reporter:	Vinson Lee <vlee>
Component:	tests	Assignee:	Paul Berry <stereotype441>
Status:	RESOLVED FIXED	QA Contact:	Eric Anholt <eric>
Severity:	blocker
Priority:	medium	CC:	jkpenner91, stereotype441
Version:	unspecified	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2013-09-06 21:04:35 UTC

piglit: 4777d6e74ec2509d6b64dc374f00abd6d98e722b (master)

tests\spec\gl-3.2\layered-rendering\clear-color.c(62) : warning C4100: 'textureType' : unreferenced formal parameter
tests\spec\gl-3.2\layered-rendering\clear-color.c(112) : error C2057: expected constant expression
tests\spec\gl-3.2\layered-rendering\clear-color.c(112) : error C2466: cannot allocate an array of constant size 0
tests\spec\gl-3.2\layered-rendering\clear-color.c(112) : error C2087: 'colorLayers' : missing subscript
tests\spec\gl-3.2\layered-rendering\clear-color.c(112) : error C2133: 'colorLayers' : unknown size


commit b576b0a685cae5f3f26a647bde0f5e5a1a825a52
Author: Jacob Penner <jkpenner91@gmail.com>
Date:   Tue Aug 27 10:02:57 2013 -0700

    GL 3.2: Test layered framebuffers clear the color attachment properly.
    
    Reviewed-by: Paul Berry <stereotype441@gmail.com>

Comment 1 Paul Berry 2013-09-10 21:07:36 UTC

Patch sent to Piglit list for review: http://lists.freedesktop.org/archives/piglit/2013-September/007284.html

Comment 2 Paul Berry 2013-09-12 18:57:50 UTC

Fixed by commit 7574eb3850882ed38cadff9bf19e6b7593a39606
Author: Paul Berry <stereotype441@gmail.com>
Date:   Mon Sep 9 14:25:07 2013 -0700

    GL 3.2: Fix layered clear color test to work with MSVC.
    
    MSVC doesn't support dynamically sized local arrays.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69054
    
    Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
    Tested-by: Vinson Lee <vlee@freedesktop.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.