| Summary: | add 512x512 to the lookup | ||
|---|---|---|---|
| Product: | Icon theme | Reporter: | Jakub Steiner <jimmac> |
| Component: | hicolor | Assignee: | Alexander Larsson <alexl> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | nekohayo |
| Version: | ALL | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
support 512x512 lookup
don't change maxsize of scalables this time |
||
|
Description
Jakub Steiner
2013-09-11 15:52:08 UTC
Created attachment 85645 [details] [review] support 512x512 lookup Changing scalable max from 256 to 512 does change what icons would be picked atm even if no 512 icons has been added yet. Why do we want to change that? (In reply to comment #2) > Changing scalable max from 256 to 512 does change what icons would be picked > atm even if no 512 icons has been added yet. Why do we want to change that? Myy understanding of MaxSize is that the icons would not get scaled up to 512 is requested, but would be padded with whitespace around MaxSize to fit. I believe if a legacy icon that provides scalables instead of highres, it should render into the 512x512 canvas. > Myy understanding of MaxSize is that the icons would not get scaled up to 512
> is requested, but would be padded with whitespace around MaxSize to fit. I
> believe if a legacy icon that provides scalables instead of highres, it
> should render into the 512x512 canvas.
This is not how Gtk+ currently handles things. Scalable directories are always scaled to fit the requested size. Threshold directories are not scaled at all inside the min-max region, but scaled outside that.
Take for example these current dirs:
[256x256/actions]
MinSize=64
Size=256
MaxSize=256
Context=Actions
Type=Scalable
[scalable/actions]
MinSize=1
Size=128
MaxSize=256
Context=Actions
Type=Scalable
And then we want to add:
[512x512/actions]
MinSize=64
Size=512
MaxSize=512
Context=Actions
Type=Scalable
If we then *also* bump scalable to MaxSize 512, then (assuming no 512 icons yet) someone requesting an image at 356 pixels will get a perfect match for scalable/actions, but 256x256/actions will be off by 100 pixels, so it will chose the scalable one instead.
If both the scalable and 256 dirs were bumped to 512 we would chose the 256 one as it has a Size that is closer. However, i don't see the need for this, even if we don't change MaxSize on scalable or 256 we will scale any of those to 512 if someone requests a 512 icon.
Created attachment 87454 [details] [review] don't change maxsize of scalables this time I put this in 0.13, but I'm having problems getting the release up. For now it is at: https://people.gnome.org/~alexl/hicolor/hicolor-icon-theme-0.13.tar.gz |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.