Bug 69578

Summary: [GM45, bisected] Piglit fbo-clear-formats GL_ARB_depth_buffer_float stencil fails
Product: Mesa Reporter: Pavel Ondračka <pavel.ondracka>
Component: Drivers/DRI/i965Assignee: Intel 3D Bugs Mailing List <intel-3d-bugs>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium CC: imamdxl8805, mark.a.janes
Version: gitKeywords: regression
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Pavel Ondračka 2013-09-19 13:44:37 UTC
Another old untracked regression I found when running piglit on last few mesa releases. This was originally mentioned in bug 59498 and fixed for newer platforms, however my GM45 still fails.

First bad commit:
commit 252573ae0fe6c928885f005cf6e77200b45601fb
Author:     Anuj Phogat <anuj.phogat@gmail.com>
AuthorDate: Mon Jan 7 15:55:31 2013 -0800
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Tue Jan 15 15:08:12 2013 -0800

    mesa: Fix GL error generation in glBlitFramebuffer()

    V2:
    If mask has GL_STENCIL_BUFFER_BIT set, the depth formats for
    readRenderBuffer and drawRenderBuffer must match unless one of the two
    buffers doesn't have depth, in which case it's not blitted, so the
    format check should be ignored.  Same comment goes for stencil formats
    in depth renderbuffers if mask has GL_DEPTH_BUFFER_BIT set.

    v3 (Kayden): Refactor code to be a bit more readable.

./bin/fbo-clear-formats GL_ARB_depth_buffer_float stencil -auto
Using test set: GL_ARB_depth_buffer_float
Testing GL_DEPTH_COMPONENT32F - no stencil.
Testing GL_DEPTH32F_STENCIL8
Unexpected GL error: GL_INVALID_OPERATION 0x502
(Error at /home/Paulie/piglit/tests/fbo/fbo-clear-formats.c:334)
PIGLIT: {'result': 'fail' }

GPU: GM45
Mesa: 602d368446e7c97225f98429ffd54b53522c3b36
Kernel: 3.10.11-100.fc18.x86_64
Libdrm: 2.4.45-1.fc18
Comment 1 Matt Turner 2017-03-22 04:48:39 UTC
Mark, does this test pass in CI?
Comment 2 Mark Janes 2017-03-22 16:07:19 UTC
It's hard for me to tell if the test passes in CI, because the bug report does not contain the test name.

The closest test name I could find was:

piglit.spec.arb_depth_buffer_float.fbo-clear-formats stencil

I think this test corresponds to the invocation specified by Pavel.  The test passes on G45.  It was working when the CI was created.

If I'm correct about the test name, then this bug can be closed.
Comment 3 Pavel Ondračka 2017-03-22 19:43:21 UTC
(In reply to Mark Janes from comment #2)
> It's hard for me to tell if the test passes in CI, because the bug report
> does not contain the test name.
> 
> The closest test name I could find was:
> 
> piglit.spec.arb_depth_buffer_float.fbo-clear-formats stencil
> 
> I think this test corresponds to the invocation specified by Pavel.  The
> test passes on G45.  It was working when the CI was created.
> 
> If I'm correct about the test name, then this bug can be closed.

Unfortunately I don't have the laptop anymore so I can't test. If this passes on your test infrastructure then it is probably fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.