Bug 69592

Summary: piglit fs-mix-vec2-vec2-bvec2 regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED DUPLICATE QA Contact:
Severity: critical    
Priority: medium CC: mattst88
Version: gitKeywords: regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2013-09-19 23:56:46 UTC
mesa: 1cc3b90d47f92aa0be2d914191fd2f46d2b127d7 (master)

$ ./bin/shader_runner generated_tests/spec/glsl-1.30/execution/built-in-functions/fs-mix-vec2-vec2-bvec2.shader_test -auto
src/mesa/state_tracker/st_glsl_to_tgsi.cpp:1986:visit: Assertion `!"Invalid ir opcode in glsl_to_tgsi_visitor::visit()"' failed.
Trace/breakpoint trap (core dumped)

(gdb) bt
#0  0x00007f8581db3d42 in _debug_assert_fail (expr=0x7f85828d83e8 "!\"Invalid ir opcode in glsl_to_tgsi_visitor::visit()\"", file=0x7f85828d7d70 "src/mesa/state_tracker/st_glsl_to_tgsi.cpp", line=1986, 
    function=0x7f85828d94ef <glsl_to_tgsi_visitor::visit(ir_expression*)::__FUNCTION__> "visit") at src/gallium/auxiliary/util/u_debug.c:278
#1  0x00007f8581c8494a in glsl_to_tgsi_visitor::visit (this=0x183f040, ir=0x185f7b0) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:1986
#2  0x00007f8581cb5146 in ir_expression::accept (this=0x185f7b0, v=0x183f040) at src/glsl/ir.h:1330
#3  0x00007f8581c8016e in glsl_to_tgsi_visitor::visit (this=0x183f040, ir=0x185ff00) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:1390
#4  0x00007f8581cb5146 in ir_expression::accept (this=0x185ff00, v=0x183f040) at src/glsl/ir.h:1330
#5  0x00007f8581c85b31 in glsl_to_tgsi_visitor::visit (this=0x183f040, ir=0x185ff90) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:2339
#6  0x00007f8581cb50fa in ir_assignment::accept (this=0x185ff90, v=0x183f040) at src/glsl/ir.h:922
#7  0x00007f8581c7f488 in glsl_to_tgsi_visitor::visit (this=0x183f040, ir=0x1856d80) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:1219
#8  0x00007f8581cb504a in ir_function::accept (this=0x1856d80, v=0x183f040) at src/glsl/ir.h:745
#9  0x00007f8581cc0c9c in visit_exec_list (list=0x184d460, visitor=0x183f040) at src/glsl/ir.cpp:1760
#10 0x00007f8581c90940 in get_mesa_program (ctx=0x7f85853b9010, shader_program=0x15ff6c0, shader=0x184d2d0) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:5062
#11 0x00007f8581c91148 in st_link_shader (ctx=0x7f85853b9010, prog=0x15ff6c0) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:5288
#12 0x00007f8581b6186e in _mesa_glsl_link_shader (ctx=0x7f85853b9010, prog=0x15ff6c0) at src/mesa/program/ir_to_mesa.cpp:3133
#13 0x00007f8581b201d7 in link_program (ctx=0x7f85853b9010, program=3) at src/mesa/main/shaderapi.c:834
#14 0x00007f8581b21365 in _mesa_LinkProgram (programObj=3) at src/mesa/main/shaderapi.c:1317
#15 0x00007f85850cbca7 in stub_glLinkProgram (program=3) at piglit/tests/util/generated_dispatch.c:17556
#16 0x00000000004054c6 in link_and_use_shaders () at piglit/tests/shaders/shader_runner.c:757
#17 0x0000000000409093 in piglit_init (argc=2, argv=0x7fffa1d9ae18) at piglit/tests/shaders/shader_runner.c:1962
#18 0x00007f85850a63b2 in run_test (gl_fw=0x7f8585394340 <glut_fw>, argc=2, argv=0x7fffa1d9ae18) at piglit/tests/util/piglit-framework-gl/piglit_glut_framework.c:140
#19 0x00007f85850a42f9 in piglit_gl_test_run (argc=2, argv=0x7fffa1d9ae18, config=0x7fffa1d9ad00) at piglit/tests/util/piglit-framework-gl.c:141
#20 0x0000000000403fb3 in main (argc=2, argv=0x7fffa1d9ae18) at piglit/tests/shaders/shader_runner.c:57
(gdb) frame 1
#1  0x00007f8581c8494a in glsl_to_tgsi_visitor::visit (this=0x183f040, ir=0x185f7b0) at src/mesa/state_tracker/st_glsl_to_tgsi.cpp:1986
1986	      assert(!"Invalid ir opcode in glsl_to_tgsi_visitor::visit()");
(gdb) l
1981	   case ir_triop_vector_insert:
1982	   case ir_binop_ldexp:
1983	   case ir_triop_csel:
1984	      /* This operation is not supported, or should have already been handled.
1985	       */
1986	      assert(!"Invalid ir opcode in glsl_to_tgsi_visitor::visit()");
1987	      break;
1988	   }
1989	
1990	   this->result = result_src;
(gdb) print ir->operation
$1 = ir_triop_csel


fd183fa02c4430e439faf6a5195f5008d34db987 is the first bad commit
commit fd183fa02c4430e439faf6a5195f5008d34db987
Author: Matt Turner <mattst88@gmail.com>
Date:   Fri Sep 6 12:36:48 2013 -0700

    glsl: Use conditional-select in mix().
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

:040000 040000 2e76899a27ccc0bd584d7265891f1a51862bf4ae 794c98855a3f3057af8e9cbb91c2dd10dd4f6590 M	src
bisect run success
Comment 1 Matt Turner 2013-09-20 00:01:40 UTC

*** This bug has been marked as a duplicate of bug 69202 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.