Bug 69617

Summary:	[PATCH] GIMP's color picker of color dialog not work, returns black
Product:	cairo	Reporter:	Massimo <sixtysix>
Component:	win32 backend	Assignee:	cairo-bugs mailing list <cairo-bugs>
Status:	RESOLVED MOVED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	quick hack

Description Massimo 2013-09-20 16:32:01 UTC

Created attachment 86200 [details]
quick hack

I've investigated GIMP's https://bugzilla.gnome.org/show_bug.cgi?id=676708,
on Windows XP, and the cause is that 'GetClipBox', on XP, for desktop's hdc 
returns NULLREGION and an empty rect. That produces an empty win32 surface 
which then, used as a source, paints nothing (do_nothing returns true).

With the attached patch GIMP's color dialog color picker returns the color
under the pointer also on XP.

Comment 1 Alexandre Prokoudine 2016-10-28 16:51:05 UTC

Three years later we keep receiving complaints from Windows users, because the patch seems to never have been applied.

Let's get over with it please :)

Comment 2 Bryce Harrington 2018-02-06 23:18:17 UTC

A patch has landed to trunk to fix bug 100793, which claims it addresses the root cause leading to this bug.

Could you please re-test against the current master trunk to see if the crash issue is still reproducible?

Comment 3 Massimo 2018-02-07 06:09:35 UTC

(In reply to Bryce Harrington from comment #2)
> A patch has landed to trunk to fix bug 100793, which claims it addresses the
> root cause leading to this bug.
> 
> Could you please re-test against the current master trunk to see if the
> crash issue is still reproducible?

I don't recall crashes related to this isssue, it was just
GIMP's color picker returning black.

Besides, I no longer have access to the 32 bit Windows XP
I had time ago. Sorry

Comment 4 GitLab Migration User 2018-08-25 13:42:07 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cairo/cairo/issues/147.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.