| Summary: | [bug] Weston won't "wake up" after two touch events | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | Brian Lovin <brian.j.lovin> |
| Component: | weston | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Set new state before emitting wake signal in weston_compsitor_wake | ||
|
Description
Brian Lovin
2013-09-23 16:07:31 UTC
I wonder if this is related to bug 69759? I think if it is a single-touch device and you were able to do that first tap without moving the finger before releasing it then the bug would be triggered and any subsequent taps would be lost. It turns out this bug has nothing to do with touch event handling because you can replicate the same problem if you try to wake up the compositor with the shift key instead. Created attachment 86846 [details] [review] Set new state before emitting wake signal in weston_compsitor_wake The wake handler set up by the shell will try to unlock the screen which works by setting up an animation which fades in the display. The animation is started by first scheduling a repaint. Subsequent repaints are scheduled whenever the previous frame is finished. However in the case of the wake up signal the state is still WESTON_COMPOSITOR_SLEEPING when the animation is started. weston_output_schedule_repaint() ignores attempts to schedule a repaint if the compositor is sleeping which means the animation never gets run and will never complete. The animation gets unstuck and continues if anything else schedules a repaint after the state has been changed so the bug only gets hit in certain conditions. The first wake up creates the lock surface which causes a redraw when the first buffer is attached so the first wake up is always ok. A redraw can be triggered in the subsequent wake ups just by moving the mouse. A good way to trigger the bug is to try to wake up the compositor by pressing the shift key. If you let the compositor go back to sleep after waking it up without unlocking it, the second press of the shift key will not cause a redraw so the animation will not run and it won't fade in. (In reply to comment #3) > Created attachment 86846 [details] [review] [review] > Set new state before emitting wake signal in weston_compsitor_wake Yup, that looks good - another great fix, Neil. commit 8b62e2043a721f4b6e6e409280f5acbde73e8dfa Author: Neil Roberts <neil@linux.intel.com> Date: Mon Sep 30 13:14:47 2013 +0100 Set new state before emitting wake signal in weston_compsitor_wake ... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.