Bug 69791

Summary: [GM45 Bisected]Boot system has <3>[ 1.894068] [drm:intel_pipe_config_compare] *ERROR* mismatch in adjusted_mode.flags(DRM_MODE_FLAG_NHSYNC) (expected 2, found 0)
Product: DRI Reporter: lu hua <huax.lu>
Component: DRM/IntelAssignee: Daniel Vetter <daniel>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: major    
Priority: high CC: carstenmattner, intel-gfx-bugs, mike.parker
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg none

Description lu hua 2013-09-25 06:21:57 UTC 
Created attachment 86505 [details]
dmesg

System Environment:
--------------------------
Arch:           x86_64
Platform:       GM45
Kernel:         (drm-intel-nightly)15425dbba39114d8dfbb12f6ddb1f39d0cae144a

Bug detailed description:
-----------------------------
It happens on GM45 with -fixes, -nightly, -queued kernel.
Boot system, <3>[  1.894068] [drm:intel_pipe_config_compare] *ERROR* mismatch in adjusted_mode.flags(DRM_MODE_FLAG_NHSYNC) (expected 2, found 0) appears in dmesg.
It is the same as Bug 66482.

Bisect shows: 2960bc9cceecb5d556ce1c07656a6609e2f7e8b0 is the first bad commit.
commit 2960bc9cceecb5d556ce1c07656a6609e2f7e8b0
Author:     Imre Deak <imre.deak@intel.com>
AuthorDate: Tue Jul 30 13:36:32 2013 +0300
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Mon Aug 5 19:04:05 2013 +0200

    drm/i915: make user mode sync polarity setting explicit

    Userspace can pass a mode with an unspecified vsync/hsync polarity
    setting. All encoders in the Intel driver take this to mean a negative
    polarity setting. The HW readout/state checker code on the other hand
    needs these flags to be explicitly set, otherwise the state checker will
    WARN about the mismatch.

    Get rid of the WARN by making the polarity setting explicit in the
    adjusted mode flags based on the requested mode flags. This will keep
    the existing behavior otherwise.

    Note that we could guess from the other timing parameters whether the
    user wanted a VESA or other standard mode and set the polarity
    accordingly. This is what the NV driver does
    (drivers/gpu/drm/nouveau/dispnv04/crtc.c), but I think that's not very
    exact and would change the existing behavior of the Intel driver.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65442
    Signed-off-by: Imre Deak <imre.deak@intel.com>
    Tested-by: cancan,feng <cancan.feng@intel.com>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 1 Daniel Vetter 2013-09-25 10:27:06 UTC 
Can you please retest with latest -fixes? Specifically

commit 1062b81598bc00e2f6620e6f3788f8f8df2f01e7
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Sep 10 11:44:30 2013 +0200

    drm/i915/tv: clear adjusted_mode.flags
Comment 2 lu hua 2013-09-26 08:26:57 UTC 
(In reply to comment #1)
> Can you please retest with latest -fixes? Specifically
> 
> commit 1062b81598bc00e2f6620e6f3788f8f8df2f01e7
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Tue Sep 10 11:44:30 2013 +0200
> 
>     drm/i915/tv: clear adjusted_mode.flags


Test on -fixes kernel(commit d32270460fee83e22ee9e6b1bfd7b486263eeb1d), it works well.
Comment 3 Daniel Vetter 2013-09-26 08:48:50 UTC 
Patch is now merged into -fixes.
Comment 4 lu hua 2013-09-29 03:07:52 UTC 
Verified.Fixed on -fixes kernel.
Comment 5 Daniel Vetter 2013-10-01 19:55:03 UTC 
*** Bug 69875 has been marked as a duplicate of this bug. ***
Comment 6 Gordon Jin 2014-01-03 01:52:00 UTC 
(give the credit to Daniel)
Comment 7 Jari Tahvanainen 2017-09-04 10:15:43 UTC 
Closing old verified+fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.