Bug 69806

Created attachment 86552 [details] [review]
call-stream: fix type of state variable

Should go to master.

Created attachment 86553 [details] [review]
remove StreamedMedia support

Created attachment 86554 [details] [review]
add telepathy-glib-dbus.h

Created attachment 86555 [details] [review]
build with telepathy-glib-1

Comment on attachment 86552 [details] [review]
call-stream: fix type of state variable

Review of attachment 86552 [details] [review]:
-----------------------------------------------------------------

Yes. This would be fine for master too.

Comment on attachment 86553 [details] [review]
remove StreamedMedia support

Review of attachment 86553 [details] [review]:
-----------------------------------------------------------------

I would be very tempted to apply this to master and bump the telepathy-farstream SONAME, even if we never actually release with that SONAME.

Comment on attachment 86554 [details] [review]
add telepathy-glib-dbus.h

Review of attachment 86554 [details] [review]:
-----------------------------------------------------------------

OK for master too.

(In reply to comment #6)
> remove StreamedMedia support
> 
> I would be very tempted to apply this to master and bump the
> telepathy-farstream SONAME, even if we never actually release with that
> SONAME.

by which I mean: bump tp_farstream_lt_current to 4 (resulting in libtelepathy-farstream.so.4)

Comment on attachment 86555 [details] [review]
build with telepathy-glib-1

Review of attachment 86555 [details] [review]:
-----------------------------------------------------------------

You also need to change:

* the .pc.in files

* the ABI (I would be inclined to change the library name to libtelepathy-farstream-1.la and reset current/revision/age to 0/0/0)

* the .gir (I'd call it TelepathyFarstream-1.gir)

* the directory in which the headers are installed (I'd move them to ${includedir}/telepathy-farstream-1/telepathy-farstream, and use -I${includedir}/telepathy-farstream-1 to compile)

Right I forgot about lib stuffs. I've added them to http://cgit.collabora.com/git/user/cassidy/telepathy-farstream.git/log/?h=next

> +PKG_CHECK_MODULES([TELEPATHY], [telepathy-glib-1 >= 0.21, telepathy-glib-1-dbus >= 0.21])

Please say 0.99.1, as a way to indicate "we've ported this to 0.99.1, but it might not be compatible with 0.99.n if compatibility has broken further".

The content of the .pc.in files also needs to change, to change the dependency from telepathy-glib to telepathy-glib-1 and telepathy-glib-1-dbus.

Created attachment 86628 [details] [review]
build with telepathy-glib-1

I updated the branch as well.

http://cgit.collabora.com/git/user/cassidy/telepathy-farstream.git/log/?h=next
updated with now a patch updating the doc module.

Pushed to 'next'.