Summary: | EDITING "Select All" crashes Writer when the document contains a footnote and starts with a table | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stephan van den Akker <stephanv778> |
Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | medium | CC: | arnaud.versini, jbfaure, michael.meeks, serval2412, stephanv778, vmiklos |
Version: | 4.2.0.0.alpha0+ Master | Keywords: | regression |
Hardware: | Other | ||
OS: | All | ||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=69893 https://bugs.freedesktop.org/show_bug.cgi?id=69979 |
||
Whiteboard: | target:4.2.0 | ||
i915 platform: | i915 features: | ||
Attachments: | example file with a footnote |
Description
Stephan van den Akker
2013-09-26 21:29:54 UTC
Created attachment 86706 [details]
example file with a footnote
I do not reproduce the crash with Version: 4.2.0.0.alpha0+ Build ID: 20b9f53e9681aa1a4e3a257a417aae0c4eb03f7d under Ubuntu 13.04 x86-64
In my case (with the attached file) ctrl+A select only the footnote.
Best regards. JBF
The test file in attachment 86706 [details] causes a crash in my LOdev.
Hi Stephan, so I open your test document and press cmd + a. On OS X 10.8.5, LO 4.1.2.2 this does not cause a crash. Neither in Version: 4.2.0.0.alpha0+ Build ID: f4d3954fc6106b3ae0ee16ab0fcde15d8cb945e3 So maybe Linux only? @FOSS: Thanks for testing. Could be linux only. Maybe someone can try in a daily build under Windows? Crash is reproducible on a different system with openSuSE 11.4 (64-bit): Build ID: 751e238c78247bec81c1c7c50bc4758b1faea151 Build ID: 4547d8c42e5b0bb456ac02fbea67059a8a1cadd7 Build ID: bcfb5f0e9b659d16b72fe0add599dd8ec1a7c098 (pulled 27 September) (In reply to comment #4) > @FOSS: Thanks for testing. Could be linux only. Surely not, because I did my tests on Ubuntu 13.04 x86-64. But perhaps OpenSuse only ;-) Best regards. JBF On pc Debian x86-64 with master sources updated today, no crash but this trace on console: warn:legacy.osl:11607:1:sw/source/core/layout/trvlfrm.cxx:2482: <SwRootFrm::CalcFrmRects(..)> - no content frame. This is a serious defect -> please inform OD No crash but a weird behavior, Ctrl + a select only the first case of the table. Oops, forgoten to say that the cursor was in the paragraph after the table, not in the table ! Tested attachment 86706 [details] on Ubuntu 12.04 (32-bit) with: Version: 4.2.0.0.alpha0+ Build ID: 981b73c98576ea297cf8244c1cbe1ece783e5ca9 Result: No crash. Same unwanted behaviour as described in comment #1 and comment #6. Observation: After removing the footnote from attachment 86706 [details] - the warnings dissapear - Ctrl-A selects the whole document Conclusion: A footnote exposes a bug in the Select All patch of vmiklos. This bug results in a crash on openSuSE systems. I can't see the crash, either. (Tried with a dbgutil on master, and with the backported patch to -4-1, which is a product build.) OTOH yes, indeed only the footnote gets selected, I'll fix that. Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=959711f1276106b0aaee69ab660f1b0d3ece5bbc fdo#69862 SwCrsrShell::ExtendedSelectAll: don't always select footnotes The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fixed in master, marking as resolved (no backport, regression is master-only). BTW, just by reading the backtrace in the description, it seems that the problem there is 1) we detect that the doc starts with a table 2) the first paragraph of the selection is still not in a table. The above commit should fix that problem as well, even if I wasn't able to reproduce it. Confirmed fixed on openSuSE 11.4 (64-bit) in LOdev:
Version: 4.2.0.0.alpha0+
Build ID: e5c370e53d8701d863d231c26ce8e5c46385e5eb
But this still doesn't work on my real world documents. After some more study the problem is reproducible by:
1 - Add a header of footer to attachment 86706 [details]
2 - Return to the main text
3 - Ctrl-A (Select All)
Expected behaviour: The whole document is selected
Actual behaviour: The content of the header or footer is selected, then Crash.
make debugrun output:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x2aaabda4e700 (LWP 23749)]
SwEditShell::_CopySelToDoc (this=0x14fc740, pInsDoc=0x2a26d30, pSttNd=0x0)
at /home/data/stephan/libreoffice-master/core/sw/source/core/edit/edglss.cxx:240
240 aPaM.Start()->nNode = aPaM.Start()->nNode.GetNode().FindTableNode()->GetIndex();
Looks to me like the same or similar problem.
@vmiklos: New bug report or reopen this one?
Stephan, please open a new one, mentioning that the new problem is triggered when you also have headers/footers. An out of the box reproducer document makes my life easier. :-) Thanks! New bug report (with reproducer document): https://bugs.freedesktop.org/show_bug.cgi?id=69979 EDITING "Select All" crashes Writer when the document contains a header or footer and starts with a table |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.