Summary: | [HSW GT3e Bisected] GLbenchmark v2.7.0 EgyptHD _FixedTime performance reduced by 20% | ||||||
---|---|---|---|---|---|---|---|
Product: | DRI | Reporter: | meng <mengmeng.meng> | ||||
Component: | DRM/Intel | Assignee: | Chris Wilson <chris> | ||||
Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||
Severity: | major | ||||||
Priority: | high | CC: | ben, eero.t.tamminen, intel-gfx-bugs | ||||
Version: | unspecified | ||||||
Hardware: | All | ||||||
OS: | Linux (All) | ||||||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=67062 | ||||||
Whiteboard: | |||||||
i915 platform: | i915 features: | ||||||
Attachments: |
|
Description
meng
2013-09-27 05:42:40 UTC
For gt3e we've meanwhile enabled eLLC. What's the numbers on latest dinq? s/dinq/-nightly of course. (In reply to comment #2) > s/dinq/-nightly of course. Kernel built on 2013-09-27 -nightly git-8153de: 129.33 -dinq git-cd2983 :127 fps -drm-intel-fixes git-d32270: 133.0 fps Hi, is eLLC enabled in above driver? Or need to do by other way? (In reply to comment #3) > (In reply to comment #2) > > s/dinq/-nightly of course. > Kernel built on 2013-09-27 > -nightly git-8153de: 129.33 > -dinq git-cd2983 :127 fps > -drm-intel-fixes git-d32270: 133.0 fps > > Hi, is eLLC enabled in above driver? Or need to do by other way? Yes. And apparently there's another regression somewhere ... Since your bisection here is the very commit that you tested to improve performance in the same test, I strongly suspect external factors. Ben, can you reproduce it? I think the situation is too confusing and the delay between when we've committed the patch and when the regression was reported was too long to be actionable. So closing as wontifx. *shrug* It was something I meant to pinpoint but I never got access to gl2.7 (In reply to comment #8) > I think the situation is too confusing and the delay between when we've > committed the patch and when the regression was reported was too long to be > actionable. So closing as wontifx. Hi, HSW mobile GT3e is added nightly testing at the end of August, then updated this machine OS, so the bug is found later. the performance still exists on -dinq git-f671d1(can't revert the bisected commit git-0d8ff1). So I reopen it. Modulo using s2tc instead of s3tc, on a i7-4950HQ: 50b44a4: 145fps, 155fps, 152fps 0d8ff15: 132fps, 136fps, 135fps d-i-n: 148fps, 152fps, 156fps Can you please confirm the magnitude of the effect you saw previously and whether it has rectified itself in drm-intel-nightly? I should note that offscreen rendering we get 187fps (vs 155fps onscreen), which is coincidentally the same magnitude as the reported regression... And to further complete the puzzle, onscreen rendering but keeping the backbuffers cached, rather than using async flips: 177fps. Rerunning the benchmark using blits: 50b44a4: 171fps, 193fps, 193fps 0d8ff15: 160fps, 174fps, 175fps d-i-n: 178fps, 178fps, 177fps d-i-n+age3: 195fps, 194fps, 193fps. So ~10% and only slightly larger than hitting uncached surfaces. Created attachment 89591 [details] [review] Prefer age3 Here's the partial revert in question. (In reply to comment #15) With above patch, the regression of the case was fixed (-dinq)git-f671d1 151,151,150, (-ding)git-f671d1 with age3 patch 186,185,185 commit c51e9701c4ad68d87baecefad6c58d051574f848 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Fri Nov 22 10:37:53 2013 +0000 drm/i915: Prefer setting PTE cache age to 3 ... merged to -fixes. Verified it. Closing old verified+fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.