Bug 69964

Summary: Rakia: Port to next
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: rakiaAssignee: Mikhail Zabaluev <mikhail.zabaluev>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium CC: xclaesse
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/xclaesse/telepathy-rakia.git/log/?h=next
Whiteboard:
i915 platform: i915 features:
Bug Depends on: 69970, 69995    
Bug Blocks: 69431    

Description Guillaume Desmottes 2013-09-30 13:10:02 UTC
.
Comment 1 Xavier Claessens 2013-10-03 15:40:46 UTC
Guillaume's branch: http://cgit.collabora.com/git/user/cassidy/telepathy-rakia/log/?h=next
Comment 2 Xavier Claessens 2013-10-03 16:45:50 UTC
Here is Guillaume's branch, rebased on master, and with extra fixes to make tests pass: http://cgit.collabora.com/git/user/xclaesse/telepathy-rakia.git/log/?h=next
Comment 3 Simon McVittie 2013-10-03 17:29:37 UTC
> fixup! test-message: Messages have been merged into Text
> I don't know why the test was expecting the first message to fail and the 2nd to succeed, but now the first succeed... It's a mystery to me...

This could be a genuine bug. The first message gets a 404 reply, analogous to HTTP 404 - we should get a failed delivery report instead of the old SendError.

Perhaps porting Rakia to Messages on master would be illuminating?
Comment 4 Simon McVittie 2013-10-03 17:30:18 UTC
The rest is fine.
Comment 5 Xavier Claessens 2013-10-04 15:15:12 UTC
(In reply to comment #3)
> > fixup! test-message: Messages have been merged into Text
> > I don't know why the test was expecting the first message to fail and the 2nd to succeed, but now the first succeed... It's a mystery to me...
> 
> This could be a genuine bug. The first message gets a 404 reply, analogous
> to HTTP 404 - we should get a failed delivery report instead of the old
> SendError.
> 
> Perhaps porting Rakia to Messages on master would be illuminating?

You were right, fixed that and pushed my branch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.