Bug 70015

Summary:	get-active-attrib-returns-all-inputs.c(85) : error C2057: expected constant expression
Product:	piglit	Reporter:	Vinson Lee <vlee>
Component:	tests	Assignee:	Eric Anholt <eric>
Status:	RESOLVED FIXED	QA Contact:	Eric Anholt <eric>
Severity:	blocker
Priority:	medium	CC:	idr, nichmack
Version:	unspecified	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2013-10-01 19:08:58 UTC

get-active-attrib-returns-all-inputs.c
tests\spec\gl-3.2\get-active-attrib-returns-all-inputs.c(85) : error C2057: expected constant expression
tests\spec\gl-3.2\get-active-attrib-returns-all-inputs.c(85) : error C2466: cannot allocate an array of constant size 0
tests\spec\gl-3.2\get-active-attrib-returns-all-inputs.c(85) : error C2133: 'name' : unknown size

commit d34a541f2bdd8bbffb32434bfef9b7c55245c6b1
Author: Nicholas Mack <nichmack@gmail.com>
Date:   Fri Sep 6 12:36:20 2013 -0700

    Test that all vertex shader inputs are enumerated by GetActiveAttrib().
    This includes built-ins such as gl_InstanceID and gl_VertexID.
    
    v2: Restructure test to check attrib names on an individual basis
    
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

Comment 1 Vinson Lee 2013-10-04 17:50:50 UTC

commit 4ce08170acc8e840b5dbb360939d511b5bf994d4
Author: Nicholas Mack <nichmack@gmail.com>
Date:   Tue Oct 1 13:12:24 2013 -0700

    Don't use dynamically sized arrays.
    
    Fix MSVC build error.
    
    get-active-attrib-returns-all-inputs.c(85) : error C2057: expected constant expression
    get-active-attrib-returns-all-inputs.c(85) : error C2466: cannot allocate an array of constant size 0
    get-active-attrib-returns-all-inputs.c(85) : error C2133: 'name' : unknown size
    
    Cc: Vinson Lee <vlee@freedesktop.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70015
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
    Tested-by: Vinson Lee <vlee@freedesktop.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.