| Summary: | gabble: fix tubes tests | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | guillaume.desmottes |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
wocky: update to master
private-tubes-factory: use self->priv pattern conn-presence: fix enum cast warning private-tube-factory: tube ID is a guint64 |
||
|
Description
Guillaume Desmottes
2013-10-02 14:06:17 UTC
Created attachment 86967 [details] [review] wocky: update to master Created attachment 86968 [details] [review] private-tubes-factory: use self->priv pattern Created attachment 86969 [details] [review] conn-presence: fix enum cast warning Created attachment 86970 [details] [review] private-tube-factory: tube ID is a guint64 Comment on attachment 86967 [details] [review] wocky: update to master Review of attachment 86967 [details] [review]: ----------------------------------------------------------------- ++ for master only Comment on attachment 86968 [details] [review] private-tubes-factory: use self->priv pattern Review of attachment 86968 [details] [review]: ----------------------------------------------------------------- ++ for master only Comment on attachment 86969 [details] [review] conn-presence: fix enum cast warning Review of attachment 86969 [details] [review]: ----------------------------------------------------------------- ++ for master, or for stable if you think it matters enough Comment on attachment 86970 [details] [review] private-tube-factory: tube ID is a guint64 Review of attachment 86970 [details] [review]: ----------------------------------------------------------------- ++ for stable, please merge to master from there. (Any idea why this is a uint64 bounded by [0, G_MAXUINT32]? Seems a bit mad.) Merged first patches to master and the the 2 others to 0.18. (In reply to comment #8) > Comment on attachment 86970 [details] [review] [review] > private-tube-factory: tube ID is a guint64 > > Review of attachment 86970 [details] [review] [review]: > ----------------------------------------------------------------- > > ++ for stable, please merge to master from there. > > (Any idea why this is a uint64 bounded by [0, G_MAXUINT32]? Seems a bit mad.) A typo I guess. I wouldn't mind changing to a guint32 in master if you want. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.