Bug 70057

Summary:	src/mesa/drivers/dri/common/xmlpool.h:103:29: fatal error: xmlpool/options.h: No such file or directory
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	Emil Velikov <emil.l.velikov>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	medium	CC:	emil.l.velikov, johannesobermayr, tstellar
Version:	git	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	configure: set HAVE_COMMON_DRI when building only swrast

Description Vinson Lee 2013-10-02 21:56:10 UTC

mesa: 61519f15aceae3e986a6e287e69684a01de3221a (master)

$ ./autogen.sh --with-dri-drivers= --with-gallium-drivers=swrast
$ make
[...]
  CC     dri_screen.lo
In file included from dri_screen.c:33:0:
../../../../../src/mesa/drivers/dri/common/xmlpool.h:103:29: fatal error: xmlpool/options.h: No such file or directory


cb1febb074ca5a9d4674c953106b467f175c4c0f is the first bad commit
commit cb1febb074ca5a9d4674c953106b467f175c4c0f
Author: Johannes Obermayr <johannesobermayr@gmx.de>
Date:   Tue Sep 17 18:09:02 2013 +0100

    gallium/targets: Make use of prebuilt libdricommon.la.
    
    libdricommon.la is available whenever a non swrast driver is built.
    All the classic dri drivers make use of the prebuild library but all
    of the gallium ones rebuild it explicitly.
    
    While we're here gallium/{llvm,soft}pipe does not require HAVE_COMMON_DRI
    thus do not set in during configure.
    
    v2: [Emil] Add commit message and drop HAVE_COMMON_DRI from configure.ac
    v3: [Emil] Rebase and resolve targets/r*/dri conflicts
    
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
    Reviewed-by: Tom Stellard <thomas.stellard@amd.com>

:100644 100644 1f0a646a61f80ca7d9e8a2c7bf2c196194734081 389ac9180a48a061b6e8c18a08b3980b4424d679 M	configure.ac
:040000 040000 c71c616f37d5946284c9faaca2db8299d66343b7 d5b72d61df382e1a1ea79b8513b9369c78ab7660 M	src

Comment 1 Johannes Obermayr 2013-10-02 22:06:52 UTC

Assign to Emil because he didn't trust my build tests and did:
" v2: [Emil] Add commit message and drop HAVE_COMMON_DRI from configure.ac"

Comment 2 Emil Velikov 2013-10-02 22:32:24 UTC

Created attachment 87010 [details] [review]
configure: set HAVE_COMMON_DRI when building only swrast

I assumed that those headers would be #ifdef'd as drisw/swrast does not use them(it cannot even parse them).

Sorry for the breakage, adding back the HAVE_COMMON_DRI hunk fixes the issue.

Comment 3 Emil Velikov 2013-10-02 22:33:58 UTC

* swrast cannot parse the driconf

Comment 4 Vinson Lee 2013-10-03 23:54:57 UTC

commit 757ec72b23bac52052c2fb98105b52699e265a24
Author: Emil Velikov <emil.l.velikov@gmail.com>
Date:   Thu Oct 3 23:23:20 2013 +0100

    configure: set HAVE_COMMON_DRI when building only swrast
    
    With commit cb1febb07, I have incorrectly removed HAVE_COMMON_DRI
    assuming that swrast does not need to build the translations for
    driconf options, as effectively swrast/drisw does not use them.
    
    With the incoming unification work of dri and drisw, it makes
    sense just to revert the offending hunk.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70057
    Reported-by: Vinson Lee <vlee@freedesktop.org>
    Tested-by: Vinson Lee <vlee@freedesktop.org>
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.