| Summary: | [Baytrail-M Regression ] machine boot up with Call Trace by plugging both VGA and eDP | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | shui yangwei <yangweix.shui> | ||||||||
| Component: | DRM/Intel | Assignee: | Ville Syrjala <ville.syrjala> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||
| Severity: | major | ||||||||||
| Priority: | medium | CC: | intel-gfx-bugs, przanoni | ||||||||
| Version: | unspecified | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| i915 platform: | i915 features: | ||||||||||
| Attachments: |
|
||||||||||
|
Description
shui yangwei
2013-10-08 07:46:23 UTC
Created attachment 87268 [details] dmesg: latest -next-queued kernel Latest -next-queued kernel: ------------------------ Kernel: (drm-intel-nightly)7feaa977a8f76312e02d916a071b7a4c0140ffcd Some additional commit info: Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Tue Oct 1 18:02:21 2013 +0300 drm/i915: Flush primary plane changes in sprite code Description: ------------------------ On latest -next-queued, the call trace is not quite the same with first bad. I have found some good commit, and the dmesg is clean, so I judge one commit is bad if the dmesg is dirty. Anything needed, please comment. Call Trace ------------------------ [ 1.748887] [drm:i9xx_update_plane], Writing base 00073000 00000000 0 0 7680 [ 1.748900] [drm:intel_edp_psr_match_conditions], PSR not supported on this platform [ 1.748914] [drm:intel_crtc_mode_set], [ENCODER:10:DAC-10] set [MODE:0:1024x768] [ 1.749578] [drm:valleyview_update_wm], Setting FIFO watermarks - A: plane=61, cursor=6, B: plane=150, cursor=6, SR: plane=0, cursor=0 [ 1.749585] ------------[ cut here ]------------ [ 1.749623] WARNING: CPU: 1 PID: 1151 at drivers/gpu/drm/i915/intel_display.c:1843 intel_enable_primary_plane+0x49/0xb5 [i915]() [ 1.749623] Primary plane already enabled [ 1.749629] Modules linked in: i915(+) video button drm_kms_helper drm freq_table [ 1.749633] CPU: 1 PID: 1151 Comm: udevd Not tainted 3.12.0-rc3_drm-intel-next-queued_7feaa9_20131008_+ #610 [ 1.749637] 0000000000000000 0000000000000009 ffffffff81704444 ffff88006fde7478 [ 1.749639] ffffffff8103319e 0000000200000007 ffffffffa00849e9 ffff880004ca4000 [ 1.749642] ffff880004ca4000 0000000000000001 0000000000000001 ffff880004c3b000 [ 1.749643] Call Trace: [ 1.749651] [<ffffffff81704444>] ? dump_stack+0x41/0x51 [ 1.749656] [<ffffffff8103319e>] ? warn_slowpath_common+0x73/0x8b [ 1.749686] [<ffffffffa00849e9>] ? intel_enable_primary_plane+0x49/0xb5 [i915] [ 1.749690] [<ffffffff8103324e>] ? warn_slowpath_fmt+0x45/0x4a [ 1.749720] [<ffffffffa00843fc>] ? assert_pipe+0x61/0xc0 [i915] [ 1.749750] [<ffffffffa00849e9>] ? intel_enable_primary_plane+0x49/0xb5 [i915] [ 1.749780] [<ffffffffa0088825>] ? valleyview_crtc_enable+0x308/0x395 [i915] [ 1.749811] [<ffffffffa008b01e>] ? __intel_set_mode+0xfd4/0x10df [i915] (In reply to comment #0) > Bisect Result: > ----------------------- > 1d5b80e5bcd2cb7333bbc1fa8abb8c5a55a870b5 is the first bad commit > commit 1d5b80e5bcd2cb7333bbc1fa8abb8c5a55a870b5 > Author: Jani Nikula <jani.nikula@intel.com> > Date: Sat Oct 5 16:13:56 2013 +0300 > > drm/i915/dp: promote clock recovery failures to DRM_ERROR Please double check the bisect. This commit only changes a couple of DRM_DEBUG_KMS prints to DRM_ERROR, and could not cause the errors in the dmesg. (In reply to comment #2) > (In reply to comment #0) > > Bisect Result: > > ----------------------- > > 1d5b80e5bcd2cb7333bbc1fa8abb8c5a55a870b5 is the first bad commit > > commit 1d5b80e5bcd2cb7333bbc1fa8abb8c5a55a870b5 > > Author: Jani Nikula <jani.nikula@intel.com> > > Date: Sat Oct 5 16:13:56 2013 +0300 > > > > drm/i915/dp: promote clock recovery failures to DRM_ERROR > > Please double check the bisect. This commit only changes a couple of > DRM_DEBUG_KMS prints to DRM_ERROR, and could not cause the errors in the > dmesg. OK, I ignored some different dirty messages. Please have a look at comment 1, I re-bisect this "call trace", sorry for the mistake. The dmesg you can reference comment 1. ------------------------------- 1c8acae33ec22ac9fa0451ea6caedf9b969f6ebe is the first bad commit commit 1c8acae33ec22ac9fa0451ea6caedf9b969f6ebe Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Tue Oct 1 18:02:20 2013 +0300 drm/i915: WARN if primary plane state doesn't match expectations Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> :040000 040000 380418c8acd495adf8bdc819eca652c60c12d8d9 e5221c4edd04fcbeb01345f72cd55ab90242b01a M drivers Reminder here: this call trace will be reproduceable while plugged in VGA && eDP. but each of them only will be good. Yeah, the calltrace in comment 1 and 3 are different, the new bisect makes much more sense. Does this issue happen only on byt or also on other platforms? I'd would be especially interesting to cross-check on a gm45 with 2 outputs, since the display hw on gm45 or pnv is very similar to byt (all the newer desktop platforms from ilk to now are _much_ different). (In reply to comment #5) > Yeah, the calltrace in comment 1 and 3 are different, the new bisect makes > much more sense. > > Does this issue happen only on byt or also on other platforms? I'd would be > especially interesting to cross-check on a gm45 with 2 outputs, since the > display hw on gm45 or pnv is very similar to byt (all the newer desktop > platforms from ilk to now are _much_ different). OK, there's a new round testing this week, and we will give you a clearly conclusion on all machine if you think it's needed. Now we are running testing, I will check gm45 and pnv tomorrow. (In reply to comment #1) > [ 1.748887] [drm:i9xx_update_plane], Writing base 00073000 00000000 0 0 > 7680 > [ 1.748900] [drm:intel_edp_psr_match_conditions], PSR not supported on > this platform > [ 1.748914] [drm:intel_crtc_mode_set], [ENCODER:10:DAC-10] set > [MODE:0:1024x768] > [ 1.749578] [drm:valleyview_update_wm], Setting FIFO watermarks - A: > plane=61, cursor=6, B: plane=150, cursor=6, SR: plane=0, cursor=0 > [ 1.749585] ------------[ cut here ]------------ > [ 1.749623] WARNING: CPU: 1 PID: 1151 at > drivers/gpu/drm/i915/intel_display.c:1843 > intel_enable_primary_plane+0x49/0xb5 [i915]() > [ 1.749623] Primary plane already enabled > [ 1.749629] Modules linked in: i915(+) video button drm_kms_helper drm > freq_table > [ 1.749633] CPU: 1 PID: 1151 Comm: udevd Not tainted > 3.12.0-rc3_drm-intel-next-queued_7feaa9_20131008_+ #610 > [ 1.749637] 0000000000000000 0000000000000009 ffffffff81704444 > ffff88006fde7478 > [ 1.749639] ffffffff8103319e 0000000200000007 ffffffffa00849e9 > ffff880004ca4000 > [ 1.749642] ffff880004ca4000 0000000000000001 0000000000000001 > ffff880004c3b000 > [ 1.749643] Call Trace: > [ 1.749651] [<ffffffff81704444>] ? dump_stack+0x41/0x51 > [ 1.749656] [<ffffffff8103319e>] ? warn_slowpath_common+0x73/0x8b > [ 1.749686] [<ffffffffa00849e9>] ? intel_enable_primary_plane+0x49/0xb5 > [i915] > [ 1.749690] [<ffffffff8103324e>] ? warn_slowpath_fmt+0x45/0x4a > [ 1.749720] [<ffffffffa00843fc>] ? assert_pipe+0x61/0xc0 [i915] > [ 1.749750] [<ffffffffa00849e9>] ? intel_enable_primary_plane+0x49/0xb5 > [i915] > [ 1.749780] [<ffffffffa0088825>] ? valleyview_crtc_enable+0x308/0x395 > [i915] > [ 1.749811] [<ffffffffa008b01e>] ? __intel_set_mode+0xfd4/0x10df [i915] I also see "Primary plane already enabled" when I boot Haswell with eDP+DP. I looked at pnv && gm45, both them have this issue. And the call trace is the same type. Created attachment 87340 [details] [review] Fix This patch should fix the problem. Please test. (In reply to comment #9) > Created attachment 87340 [details] [review] [review] > Fix > > This patch should fix the problem. Please test. Works for me! :) Haswell eDP+DP. (In reply to comment #9) > Created attachment 87340 [details] [review] [review] > Fix > > This patch should fix the problem. Please test. Great! This patch also works on my device. When you insert the change into latest source, I will close it. commit 4c5af3fb36003864f0b3f3930ee2f678ad2eb3e8 Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Wed Oct 9 17:24:57 2013 +0300 drm/i915: Populate primary_disabled in intel_modeset_readout_hw_state() There is no call trace any more.Close it. Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.