Bug 70296

Summary: FN keys not working on Samsung 900x3a
Product: systemd Reporter: mpell
Component: generalAssignee: systemd-bugs
Status: RESOLVED FIXED QA Contact: systemd-bugs
Severity: minor    
Priority: low CC: mpell, victor.engmark
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch to fix the FN keys on the 900x3a
Applied fixes to current git

Description mpell 2013-10-08 21:24:28 UTC
Created attachment 87304 [details]
Patch to fix the FN keys on the 900x3a

The key codes don't match the described key. Also the key
identifier strings are missing. I used evtest to find the correct key codes, changed the comments to match the default windows behavior and added key
identifier strings based on how they are used on other models. I hope this helps.
Comment 1 Zbigniew Jedrzejewski-Szmek 2013-10-10 16:02:13 UTC
Does http://cgit.freedesktop.org/systemd/systemd/commit/?id=35bffce fix things for you?
Comment 2 mpell 2013-10-11 18:21:10 UTC
Since dmi:bvnPhoenixTechnologiesLtd.:bvr04HL:bd03/08/2011:svnSAMSUNGELECTRONICSCO.,LTD.:pn90X3A:pvr0.1:rvnSAMSUNGELECTRONICSCO.,LTD.:rn90X3A:rvrFAB1:cvnSAMSUNGELECTRONICSCO.,LTD.:ct9:cvr0.1: is the modalias for me, that patch wouldn't change anything. But after applying my patch, running udevadm hwdb --update and a reboot, the KDE hotkey manager can recognize the keys and even sets the keyboard brightness keys to change the keyboard brightness, which doesn't work but is probably irrelevant to this bug. But if someone could tell me where to look to integrate the keyboard brightness into KDE, I would be grateful. Then I could put away my custom scripts and help other people with similar problems.
Comment 3 mpell 2013-10-14 20:00:08 UTC
Just to make sure I also applied http://cgit.freedesktop.org/systemd/systemd/commit/?id=35bffce in addition to my patch and it still works. So I would be grateful, if someone could apply my patch.
Comment 4 Zbigniew Jedrzejewski-Szmek 2013-10-14 23:20:37 UTC
WORKSFORME would apply if the patch wasn't needed. The bug is still valid, iiuc.
Comment 5 Victor Engmark 2014-01-06 23:18:40 UTC
Can't this be merged very simply? Or is there more work left? The hardware has been out a few years now, and people have been asking for better Fn key support for some time in other places like Launchpad and Stack Overflow.
Comment 6 Zbigniew Jedrzejewski-Szmek 2014-01-06 23:29:41 UTC
(In reply to comment #5)
> Can't this be merged very simply? Or is there more work left? The hardware
> has been out a few years now, and people have been asking for better Fn key
> support for some time in other places like Launchpad and Stack Overflow.
Somebody with this hardware needs to (a) verify that current git version doesn't work, and is it doesn't, (b) prepare a patch against current sources.

Steps (a) can be done pulling the current hwdb file (http://cgit.freedesktop.org/systemd/systemd/plain/hwdb/60-keyboard.hwdb), installing it in /etc/udev/hwdb.d/, running udevadm hwdb --update.

Martin Pitt who maintains keyboard mapping applied a different fix than the one proposed by the reporter, so the original patch needs to be verified/updated.
Comment 7 mpell 2014-01-07 00:16:58 UTC
Created attachment 91571 [details] [review]
Applied fixes to current git

As requested, I applied the same fixes as before to the current git.
Comment 8 mpell 2014-01-07 00:24:37 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Can't this be merged very simply? Or is there more work left? The hardware
> > has been out a few years now, and people have been asking for better Fn key
> > support for some time in other places like Launchpad and Stack Overflow.
> Somebody with this hardware needs to (a) verify that current git version
> doesn't work, and is it doesn't, (b) prepare a patch against current sources.
> 
> Steps (a) can be done pulling the current hwdb file
> (http://cgit.freedesktop.org/systemd/systemd/plain/hwdb/60-keyboard.hwdb),
> installing it in /etc/udev/hwdb.d/, running udevadm hwdb --update.
> 
> Martin Pitt who maintains keyboard mapping applied a different fix than the
> one proposed by the reporter, so the original patch needs to be
> verified/updated.

Ok, I did step (a) and also rebooted since it doesn't take effect otherwise. > The FN keys in question don't work.
Then I applied my fixes, ran udevadm hwdb --update, rebooted. > The FN keys in question work again.
Then as you can already see, I did (b) :)

I hope you can merge it now since I plan on selling my 900x3a in the next few weeks or months and can't take care of this problem anymore afterwards.
Comment 9 Zbigniew Jedrzejewski-Szmek 2014-01-07 00:50:14 UTC
Applied in http://cgit.freedesktop.org/systemd/systemd/commit/?id=dfa2ea2,
but I modified your patch to only modify the mappings for the 90X3A modalias string that you have. It seems likely that the order or keys is changed between models.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.