Summary: | FN keys not working on Samsung 900x3a | ||
---|---|---|---|
Product: | systemd | Reporter: | mpell |
Component: | general | Assignee: | systemd-bugs |
Status: | RESOLVED FIXED | QA Contact: | systemd-bugs |
Severity: | minor | ||
Priority: | low | CC: | mpell, victor.engmark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Patch to fix the FN keys on the 900x3a
Applied fixes to current git |
Does http://cgit.freedesktop.org/systemd/systemd/commit/?id=35bffce fix things for you? Since dmi:bvnPhoenixTechnologiesLtd.:bvr04HL:bd03/08/2011:svnSAMSUNGELECTRONICSCO.,LTD.:pn90X3A:pvr0.1:rvnSAMSUNGELECTRONICSCO.,LTD.:rn90X3A:rvrFAB1:cvnSAMSUNGELECTRONICSCO.,LTD.:ct9:cvr0.1: is the modalias for me, that patch wouldn't change anything. But after applying my patch, running udevadm hwdb --update and a reboot, the KDE hotkey manager can recognize the keys and even sets the keyboard brightness keys to change the keyboard brightness, which doesn't work but is probably irrelevant to this bug. But if someone could tell me where to look to integrate the keyboard brightness into KDE, I would be grateful. Then I could put away my custom scripts and help other people with similar problems. Just to make sure I also applied http://cgit.freedesktop.org/systemd/systemd/commit/?id=35bffce in addition to my patch and it still works. So I would be grateful, if someone could apply my patch. WORKSFORME would apply if the patch wasn't needed. The bug is still valid, iiuc. Can't this be merged very simply? Or is there more work left? The hardware has been out a few years now, and people have been asking for better Fn key support for some time in other places like Launchpad and Stack Overflow. (In reply to comment #5) > Can't this be merged very simply? Or is there more work left? The hardware > has been out a few years now, and people have been asking for better Fn key > support for some time in other places like Launchpad and Stack Overflow. Somebody with this hardware needs to (a) verify that current git version doesn't work, and is it doesn't, (b) prepare a patch against current sources. Steps (a) can be done pulling the current hwdb file (http://cgit.freedesktop.org/systemd/systemd/plain/hwdb/60-keyboard.hwdb), installing it in /etc/udev/hwdb.d/, running udevadm hwdb --update. Martin Pitt who maintains keyboard mapping applied a different fix than the one proposed by the reporter, so the original patch needs to be verified/updated. Created attachment 91571 [details] [review] Applied fixes to current git As requested, I applied the same fixes as before to the current git. (In reply to comment #6) > (In reply to comment #5) > > Can't this be merged very simply? Or is there more work left? The hardware > > has been out a few years now, and people have been asking for better Fn key > > support for some time in other places like Launchpad and Stack Overflow. > Somebody with this hardware needs to (a) verify that current git version > doesn't work, and is it doesn't, (b) prepare a patch against current sources. > > Steps (a) can be done pulling the current hwdb file > (http://cgit.freedesktop.org/systemd/systemd/plain/hwdb/60-keyboard.hwdb), > installing it in /etc/udev/hwdb.d/, running udevadm hwdb --update. > > Martin Pitt who maintains keyboard mapping applied a different fix than the > one proposed by the reporter, so the original patch needs to be > verified/updated. Ok, I did step (a) and also rebooted since it doesn't take effect otherwise. > The FN keys in question don't work. Then I applied my fixes, ran udevadm hwdb --update, rebooted. > The FN keys in question work again. Then as you can already see, I did (b) :) I hope you can merge it now since I plan on selling my 900x3a in the next few weeks or months and can't take care of this problem anymore afterwards. Applied in http://cgit.freedesktop.org/systemd/systemd/commit/?id=dfa2ea2, but I modified your patch to only modify the mappings for the 90X3A modalias string that you have. It seems likely that the order or keys is changed between models. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 87304 [details] Patch to fix the FN keys on the 900x3a The key codes don't match the described key. Also the key identifier strings are missing. I used evtest to find the correct key codes, changed the comments to match the default windows behavior and added key identifier strings based on how they are used on other models. I hope this helps.