Bug 70323

Summary: can not connect to google/jabber account if 1st authentication is failed
Product: Telepathy Reporter: Corentin Lecouvey <corentin.lecouvey>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: empathy log file

Description Corentin Lecouvey 2013-10-09 15:35:06 UTC
Created attachment 87348 [details]
empathy log file

How to reproduce :
- open a chat client (Emptathy)
- create a google account and enter a bad google password
--> failed authentication popup appears asking to re-enter the password
- enter the correct google password

Expected outcome : 
User should be connected to his google account

Current outcome :
User is not connected to his google account.


Workaround :
- In Empathy, user can enter the correct password in the "Edit Connection Parameters..." menu and then connects to his google account.
- Or user has to delete/create his google account with the correct password. 


Conclusion :
I think this bug comes from telepathy-gabble since I've also faced this bug using Pidgin client.
I've also met this issue with my jabber account.


According to "log_empathy_authentication_issue.txt" attached log file, 
when user enters a bad password, it seems to be correctly detected (line 573 : "auth_failed: wocky-sasl-auth.c:274: Authentication failed!: Authentication failed: not-authorized"), 
but then when user enters the correct password, I feel there is a problem at line 1354: "gabble_server_sasl_channel_start_mechanism_with_data (server-sasl-channel.c:530): cannot start: state 1 != Not_Started", and then authentication failed is detected.


Context :
Fedora 19 up-to-date
telepathy-gabble 0.18.1
empathy 3.8.4
Comment 1 Simon McVittie 2013-10-09 16:17:40 UTC
(In reply to comment #0)
> - open a chat client (Emptathy)
> - create a google account

From your log it appears this is a Telepathy-specific Google account rather than a GNOME Online Accounts Google account.

> According to "log_empathy_authentication_issue.txt" attached log file, 
> when user enters a bad password, it seems to be correctly detected (line 573
> : "auth_failed: wocky-sasl-auth.c:274: Authentication failed!:
> Authentication failed: not-authorized"), 
> but then when user enters the correct password, I feel there is a problem at
> line 1354: "gabble_server_sasl_channel_start_mechanism_with_data
> (server-sasl-channel.c:530): cannot start: state 1 != Not_Started", and then
> authentication failed is detected.

Either the channel has CanTryAgain = False (in which case Empathy should just close it, and can try again when connection is re-attempted), or it has CanTryAgain = True but doesn't implement it correctly.

In this case it looks as though it's Empathy that's wrong:

    case PROP_CAN_TRY_AGAIN:
      /* Wocky can't retry SASL authentication (although XMPP can) */
      g_value_set_boolean (value, FALSE);
      break;

Alternatively, someone could redo Wocky's authentication API to support attempting authentication more than once on the same connection.
Comment 2 GitLab Migration User 2019-12-03 19:59:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/266.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.