Summary: | reserved identifier violation | ||
---|---|---|---|
Product: | XCB | Reporter: | Markus Elfring <Markus.Elfring> |
Component: | Library | Assignee: | xcb mailing list dummy <xcb> |
Status: | RESOLVED FIXED | QA Contact: | xcb mailing list dummy <xcb> |
Severity: | trivial | ||
Priority: | lowest | ||
Version: | 1.0 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Markus Elfring
2013-10-20 16:54:23 UTC
It's certainly not a high priority, and it's unlikely this will ever cause an issue, but sure, we ought to switch to something like FOO_H_INCLUDED. Unless you provide patches, I doubt that anyone will ever work on this. Having this with and without underscores it just equally likely to run into a collision, so there is no point. (In reply to comment #2) I could show a patch after a basic clarification for acceptance of corresponding changes. How do you think about to avoid that this software depends on undefined behaviour? https://www.securecoding.cert.org/confluence/display/seccode/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106 While the standard may not define the behavior, all our supported compilers do, so we don't need to avoid it. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.