Bug 70964

Summary:	Virtual surround sink makes pavucontrol window too wide
Product:	PulseAudio	Reporter:	Tanu Kaskinen <tanuk>
Component:	pavucontrol	Assignee:	pulseaudio-bugs
Status:	RESOLVED FIXED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart, patrakov
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	pavucontrol screenshot

Description Tanu Kaskinen 2013-10-28 16:48:57 UTC

Created attachment 88237 [details]
pavucontrol screenshot

(This bug report is copied from a mail[1] that was sent to the mailing list.)

Hello.

Just for testing, I have enabled the virtual surround sink:

    load-module module-virtual-surround-sink hrir=/usr/share/hrir_listen/hrirs/hrir-1004.wav

An immediate consequence is that pavucontrol wants to be wider than my 1920x1080 laptop screen (albeit at 144 dpi) and cannot be shrunk below 2244 pixels. A screenshot is attached that clearly demonstrates the too-wide label that struts everything else horizontally. Could you please remove redundant text from that label, or allow it to wrap?

[1] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/17418

Comment 1 Alexander E. Patrakov 2013-10-28 16:55:33 UTC

I'd say I'll even take this bug. A rewrite of the sink is going to be posted to the list soon-ish.

Comment 2 Alexander E. Patrakov 2013-12-13 12:08:57 UTC

Unfortunately, I could not find time to fix this bug. However, Sebastian Wick <sebastian@sebastianwick.net> did, and his patch is now available in this e-mail thread:

http://lists.freedesktop.org/archives/pulseaudio-discuss/2013-December/019400.html

I have tested the patch and it mostly fixes the issue. One ugly thing remains, though, and here is how to reproduce it:

1. Configure pulseaudio to use Built-In Audio Analog Stereo as the fallback device.
2. Load module-echo-cancel (just for a sink with a long name).
3. Play something. It should go through "Built-In Audio Analog Stereo" by default.
4. Start pavucontrol, shrink its window.
5. Using pavucontrol, move that stream to "Built-in Audio Analog Stereo (echo cancelled with Built-in Audio Analog Stereo)".

Result: the stream title ellipsized to just "...", and the combo box that allows to select the device becomes wider than the window. I'd argue that it either should be initially as wide as its widest item (i.e. the widest sink name in this case), or that the sink names should also be ellipsized.

Comment 3 Alexander E. Patrakov 2014-05-09 18:42:22 UTC

Fixed with the following commit:

http://cgit.freedesktop.org/pulseaudio/pavucontrol/commit/?id=35e844d2b2cf35f5a4cb29b1e32f4f1fa95dda7b

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.