|
Description
Simon McVittie
2013-11-05 13:01:58 UTC
Created attachment 88707 [details] [review] [spec next 1/2] Change all namespaces from im.telepathy1 to im.telepathy.v1 We don't own telepathy1.im, but we do own telepathy.im. Created attachment 88708 [details] [review] [spec next 2/2] Fix one remaining instance of org.freedesktop.Telepathy Created attachment 88709 [details] [review] [tp-glib next 1/4] TpAccountManager: simplify restart logic now that the AM is activatable This also fixes a bug: the name of the AM for Telepathy1 is MissionControl6, not MissionControl5. Created attachment 88710 [details] [review] [tp-glib next 2/4] [temporary] Update spec for im.telepathy.v1 namespace This commit is useful for testing, but when the corresponding telepathy-spec patch has been merged, it should be replaced by a real telepathy-spec release. Created attachment 88711 [details] [review] [tp-glib next 3/4] Replace im.telepathy1 with im.telepathy.v1 This also fixes a few uses of im.telepathy1 in object paths in Logger code, which was presumably a misuse of sed. Created attachment 88713 [details] [review] [tp-glib next 4/4] Replace some remaining uses of org.freedesktop.Telepathy Created attachment 88714 [details] [review] [MC next 1/2] Fix some leftover references to mc-wait-for-name Created attachment 88715 [details] [review] [MC next 2/2] Re-namespace from im.telepathy1 to im.telepathy.v1 Created attachment 88717 [details] [review] [haze next 1/1] Use im.telepathy.v1 namespace Created attachment 88718 [details] [review] [gabble next 1/1] Re-namespace to im.telepathy.v1 Created attachment 88724 [details] [review] [salut next 1/1] Re-namespace to im.telepathy.v1 telepathy-farstream doesn't appear to need changes. Something that Rakia depends on seems to have regressed; it no longer passes tests on my (Debian unstable) laptop, on either the master or next branch. Still to do: * Empathy (might not need changes? hopefully not) * Folks (might not need changes) * Idle * Rakia (if anyone can run its tests, or untested) +1 Created attachment 88833 [details] [review] [idle next 1/2] Re-namespace to im.telepathy.v1 Created attachment 88834 [details] [review] [idle next 1/2] .gitignore: ignore all of build-aux --- Not related, but trivial. Comment on attachment 88707 [details] [review] [spec next 1/2] Change all namespaces from im.telepathy1 to im.telepathy.v1 in 0.99.5 Created attachment 89079 [details] [review] [mc next 1/2] add one more missing "v1" This fixes a clean autogen/build. Created attachment 89080 [details] [review] [mc next 2/2] Make internal ID of gschema consistent with its filename --- Or I could rename the schema back to im.telepathy.MissionControl if people prefer, or call it im.telepathy.MissionControl6, or whatever. The bike shed should be blue. Created attachment 89081 [details] [review] [rakia next 1/1] Re-namespace to im.telepathy.v1 Created attachment 89082 [details] [review] [idle next 2/2 v2] Re-namespace to im.telepathy.v1 --- Now with required telepathy-glib version set to 0.99.5. I swapped the order of patches to put the really trivial one first. Comment on attachment 89079 [details] [review] [mc next 1/2] add one more missing "v1" Review of attachment 89079 [details] [review]: ----------------------------------------------------------------- Do we really want to switch schemas for each TP update? And so have to deal with settings migration, etc. Comment on attachment 89081 [details] [review] [rakia next 1/1] Re-namespace to im.telepathy.v1 Review of attachment 89081 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 89082 [details] [review] [idle next 2/2 v2] Re-namespace to im.telepathy.v1 Review of attachment 89082 [details] [review]: ----------------------------------------------------------------- ++ (In reply to comment #23) > Comment on attachment 89079 [details] [review] [review] > [mc next 1/2] add one more missing "v1" ... > Do we really want to switch schemas for each TP update? And so have to deal > with settings migration, etc. MC fails to distcheck without this patch. If you would prefer to delete the "v1", then we'll have to rename the file back to how it used to be, instead. IMO, if we have to do an im.telepathy.v2 too soon, then something has gone wrong. I don't think the name of this schema actually matters as long as it doesn't collide with anything else, because it points to "/org/gnome/empathy/" (and `dconf dump` confirms that that's where this setting is actually kept). (In reply to comment #26) > (In reply to comment #23) > > Comment on attachment 89079 [details] [review] [review] [review] > > [mc next 1/2] add one more missing "v1" > ... > > Do we really want to switch schemas for each TP update? And so have to deal > > with settings migration, etc. > > MC fails to distcheck without this patch. If you would prefer to delete the > "v1", then we'll have to rename the file back to how it used to be, instead. > > IMO, if we have to do an im.telepathy.v2 too soon, then something has gone > wrong. > > I don't think the name of this schema actually matters as long as it doesn't > collide with anything else, because it points to "/org/gnome/empathy/" (and > `dconf dump` confirms that that's where this setting is actually kept). Fair enough; ++ Comment on attachment 88834 [details] [review] [idle next 1/2] .gitignore: ignore all of build-aux Fixed in git for 0.99.5 Comment on attachment 89082 [details] [review] [idle next 2/2 v2] Re-namespace to im.telepathy.v1 Fixed in git for 0.99.5 Comment on attachment 89081 [details] [review] [rakia next 1/1] Re-namespace to im.telepathy.v1 fixed in git for Rakia 0.99.5 Remaining (MC) patches in git for 0.99.5. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.