| Summary: | polkitbackendsessionmonitor.c does not compile | ||
|---|---|---|---|
| Product: | PolicyKit | Reporter: | Xabier Rodríguez <calvaris> |
| Component: | libpolkit | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
| Severity: | critical | ||
| Priority: | medium | CC: | walters |
| Version: | unspecified | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch
0001-Don-t-discard-error-data-returned-by-polkit_system_b.patch |
||
My fault, sorry about that, I wasn't building the ConsoleKit backend. Pushed to master. Thanks very much for the patch! (In reply to comment #1) > My fault, sorry about that, I wasn't building the ConsoleKit backend. > > Pushed to master. Thanks very much for the patch! You are welcome. Now I realized that I should have added the bugzilla url to the commit description :) (In reply to comment #2) > Now I realized that I should have added the bugzilla url to > the commit description :) Please do in the future, but in this case the patch is self-justifying enough that it doesn't really matter. Where the Bugzilla links become very valuable is more complex/less-obvious patches with longer debate history. Created attachment 89059 [details] [review] 0001-Don-t-discard-error-data-returned-by-polkit_system_b.patch Shouldn't it be like this, consistent with the systemd variant? (Only compile-tested on a systemd box.) Comment on attachment 89059 [details] [review] 0001-Don-t-discard-error-data-returned-by-polkit_system_b.patch Review of attachment 89059 [details] [review]: ----------------------------------------------------------------- Yes, true. I was too quick to review... Looks good. Comment on attachment 89059 [details] [review] 0001-Don-t-discard-error-data-returned-by-polkit_system_b.patch Review of attachment 89059 [details] [review]: ----------------------------------------------------------------- Commited. (In reply to comment #4) > Created attachment 89059 [details] [review] [review] > 0001-Don-t-discard-error-data-returned-by-polkit_system_b.patch > > Shouldn't it be like this, consistent with the systemd variant? > > (Only compile-tested on a systemd box.) My bad, sorry. As the original call didn't use any other parameter I just checked that NULL in both places was harmless. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 88985 [details] Patch I don't have an freedesktop permissions to push it myself.