Bug 7192

Created attachment 5877 [details]
File causing the WARNING

The file http://johannes.sipsolutions.net/files/uspat20030042984a1.pdf causes the same message to be printed out but obviously there's no telling whether the same action is unimplemented or not (some sort of number might be good).

The file was obtained via depatisnet.de's full pdf link.

Still happens with evince 0.8.3 and poppler 0.5.4 on Gentoo.

There's also an ubuntu bug about this with test cases here: https://bugs.launchpad.net/poppler/+bug/125498

Created attachment 12623 [details]
Another file causing the warning

Here's another testcase with the same warning. Error is seen in poppler-0.6.2, evince-2.20.1 (on Gentoo).

Hi,

This comes from the fact that the index has entries which do not point
to page numbers.  For ex. in the first attached doc, the problem comes
from the last entry, Stichwortverzeichnis.  In the 2nd, from CERIAS...

To check this, you can put before line glib/poppler-document.cc:1054
(from trunk) the line:
     printf ("alfa title=%s, link_action=%p\n", title, link_action);
you will see that link_action is null for the titles I specify above.

I do not know if this is a document error, I am trying to read the pdf
reference.  I ask myself if the index is found in the pdf file, or it
is automatically generated by poppler, in the latter case being a bug of
poppler.  Do someone know the answer?

Greetings,
Eugen Dedu

Created attachment 15060 [details] [review]
Include the NONE action/dest

Please check if this patch/fix is correct.

Hi,

In the two documents attached, there is an index/outline item which has no destination.

From pdf reference v.1.7 (http://www.adobe.com/devnet/acrobat/pdfs/pdf_reference.pdf), section 8.2.2, page 586, the destination (the actions too) is optional for outline items and annotations, but required for actions and remote actions, so no warning should be displayed for outline items (such as the two documents attached).

So poppler should return no action when the dest/action is optional and is not present in the pdf file, but POPPLER_ACTION_NONE (for ex.) does not exist.

(By the way, I notice that PopplerDestType is not used, the destinations being considered as actions.  For ex., a "grep -r PopplerDestType ." shows no usage of this type.  Also, poppler/Outline.cc:78:
     78   if (!dict->lookup("Dest", &obj1)->isNull()) {
     79     action = LinkAction::parseDest(&obj1);
     80   } else {
     81       obj1.free();
     82     if (!dict->lookup("A", &obj1)->isNull()) {
     83         action = LinkAction::parseAction(&obj1);
     84   }
shows that destinations and actions are treated in the same manner, as actions.)

Therefore, I propose the attached patch in my previous comment.  I do not know well the poppler application, so please check if I modified all the needed files.

Cheers,
Eugen Dedu

Hi,

Has anyone any comment on my previous patch?  Is it good for you?

Cheers,
Eugen Dedu

I've just applied the patch, removing the POPPLER_DEST_NONE thing since I don't think it's really needed. 

Thank you very much for the patch. 

Thank you.

IMO this means that the API of poppler has changed: any application (its developers) using it should be informed that another type has been added.  For ex., evince should use
    case ...NONE:
        break;  // instead of printing a warning/error
or something like this.

Also, imagine an application which uses :
    if (action != ...UNKNOWN)
        ...

Let me know what do you think: is this important?

Cheers,
Eugen Dedu

All docs mentioned in this bug report don't show the warning anymore. Closing.