Bug 72068

Summary:	KHR_gl_texture_2D_image broken for mipmap levels not on tile boundary
Product:	Mesa	Reporter:	Ander Conselvan de Oliveira <conselvan2>
Component:	Drivers/DRI/i965	Assignee:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Status:	RESOLVED MOVED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	normal
Priority:	medium	CC:	eric
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Ander Conselvan de Oliveira 2013-11-27 12:19:39 UTC

KHR_gl_texture_2D_image is broken on at least SNB for mipmap levels that fall outside of a tile boundary since the following commit:

commit f217791ee27bdd10817109391243ffac5564daad
Author: Eric Anholt <eric@anholt.net>
Date:   Wed Aug 28 12:06:31 2013 -0700

    i965/gen7: Use the base_level field of the sampler to handle GL's BASE_LEVEL.


It seems that after this commit, the tile offsets set in intel_set_texture_image_region() are ignored.

Comment 1 Abdiel Janulgue 2013-12-06 19:41:49 UTC

Fix coming up. I've added some additional changes to completely remove x/y tiling offsets dependency and solely rely on level/layer fields in surface_state instead.

Comment 2 Abdiel Janulgue 2013-12-09 16:08:46 UTC

patch sent in mailing list for review.

Comment 3 Matt Turner 2014-06-10 19:25:41 UTC

What's the status of this bug? I see that the patches were sent in December and Jordan had a comment that needed addressing... and then nothing?

Comment 4 Abdiel Janulgue 2014-06-11 05:35:17 UTC

(In reply to comment #3)
> What's the status of this bug? I see that the patches were sent in December
> and Jordan had a comment that needed addressing... and then nothing?

The concerns that Jordan raised were from the complete removal of the tiled offsets. I didn't proceed with that direction because there were already some piglit failures on my implementation of the blorp fixes, as it only supported single-sampled layered rendering. I think Topi took over the removal of the tiling offsets tasks as it involved much more than my initial approach.

Patches 1-3 in the series, however, in itself fixed the KHR_gl_texture_2D_image bug mentioned in this report. Nobody commented on those specific patches.

On the other hand, I think Ander would like to remove the KHR_gl_texture_2D_image feature if I remember the discussion with him correctly? He might want to comment here what is the status of that decision.

Comment 5 Ander Conselvan de Oliveira 2014-06-11 07:28:55 UTC

(In reply to comment #4)
> On the other hand, I think Ander would like to remove the
> KHR_gl_texture_2D_image feature if I remember the discussion with him
> correctly? He might want to comment here what is the status of that decision.

I don't think that was ever my intention, but I couldn't find any real world users of the extension. I was doing some refactoring of the DRI image extension implementation in i965, and wanted to make sure it wouldn't break anything. There were some problems with that approach though, so I pursued a different one to achieve what I needed. As things stands now, I'm not blocked by this bug.

Comment 6 GitLab Migration User 2019-09-25 18:49:50 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1401.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.