| Summary: | Crash when mounting ISO image | ||
|---|---|---|---|
| Product: | udisks | Reporter: | Milan Bouchet-Valat <nalimilan> |
| Component: | general | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | medium | CC: | bugs, bugzilla, i.gnatenko.brain, jalalsfs, rdieter |
| Version: | unspecified | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | proposed patch | ||
|
Description
Milan Bouchet-Valat
2013-12-21 19:42:04 UTC
Same issue here, I can mount the iso image files by using mount -t iso9660 -o loop /path/image.iso /mnt/iso But the problem when I try to mount the ISO files from GUI, I tried it with 'dolphin' and 'thunar', the same issue, it tells that: Error attaching disk image: GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) (g-dbus-error-quark, 4) And: Object::connect: No such signal org::freedesktop::UPower::DeviceAdded(QDBusObjectPath) Object::connect: No such signal org::freedesktop::UPower::DeviceRemoved(QDBusObjectPath) QDBusConnection: name 'org.freedesktop.UDisks2' had owner '' but we thought it was ':1.306' I use Fedora 20 as well. Similar issue with Debian sid. I think it might be a race, as wait_for_loop_object() will try and get an object that doesn't exist yet. udisks_daemon_find_block_by_device_file() fails and returns NULL. Starting "Disks" after trying to mount it will work (whatever you tried to mount is now mounted), likely because the system has settled and the device is finally mounted. Created attachment 91828 [details] [review] proposed patch From a quick look, would this simple test fix the issue? If for some reason we're unable to get a UDisksObject instance, just bail out and let udisks_daemon_wait_for_object_sync() continue with the loop and call the wait_func again after a short break. Hopefully the object we're looking for will arrive until then. Comment on attachment 91828 [details] [review] proposed patch Review of attachment 91828 [details] [review]: ----------------------------------------------------------------- I've tested this patch and it fixes bug. Tested-by: Igor Gnatenko <i.gnatenko.brain@gmail.com> Comment on attachment 91828 [details] [review] proposed patch Review of attachment 91828 [details] [review]: ----------------------------------------------------------------- Yeah, looks good to me - thanks! Please commit it to master. ...and please prepare us a backport at some point. ;-) Comment on attachment 91828 [details] [review] proposed patch Where should I copy this patch? and how? Looks good to me, I committed Tomas' patch to http://cgit.freedesktop.org/udisks/commit/?id=f6bce1 . Thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.