Bug 73018

Summary:	piglit tests not run with --no-concurrency option
Product:	piglit	Reporter:	Vinson Lee <vlee>
Component:	infrastructure	Assignee:	Eric Anholt <eric>
Status:	RESOLVED FIXED	QA Contact:	Eric Anholt <eric>
Severity:	blocker
Priority:	medium	CC:	baker.dylan.c
Version:	unspecified	Keywords:	regression
Hardware:	x86-64 (AMD64)
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2013-12-24 20:27:42 UTC

piglit: 52bce82ddb8fc4b2dce95af0908abf4054591b77 (master)

Most piglit tests are skippped when using the --no-concurrency option.

This command only runs 307 of the piglit tests.

$ ./piglit-run.py --no-concurrency tests/quick.tests results/quick


d525a0cededab9eff43d7597a3593d843428a68b is the first bad commit
commit d525a0cededab9eff43d7597a3593d843428a68b
Author: Dylan Baker <baker.dylan.c@gmail.com>
Date:   Thu Dec 5 14:02:18 2013 -0800

    Add new concurrency option

    This patch adds a new concurrency option that runs all tests out of a
    multi-threaded pool, ignoring their request to be threaded or not. This
    new option is mutually exclusive with the -1/--no-concurrency option.

    Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>

:040000 040000 bd635390907f6c11901cc5eb29b2d5028da824bd 2a0a05552b391faf358e7817d29a6693c832cbc4 M      framework
:100755 100755 0d3d1be3a8229485c30e3e4900e3fff0daac17fc c4bed93c6250e4bd87e7b57a44ad4915102e328d M      piglit-run.py

Comment 1 Vinson Lee 2013-12-31 07:34:51 UTC

commit b170bb98e53c0f5c718090efc8efa5a0513db349
Author: Dylan Baker <baker.dylan.c@gmail.com>
Date:   Tue Dec 24 21:32:12 2013 -0800

    Fix concurrency bug.
    
    Commit d525a0cededab9eff43d7597a3593d843428a68b introduces a bug into
    the -1/--no-concurrency option that causes only tests exculsively marked
    as non-concurrent to be run.
    
    This patch addresses that bug, by adding all tests to a pool with a
    single thread, rather than only adding the tests explicitly requesting serial
    run when using the -1/--no-concurrency
    
    bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73018
    Tested-by: Vinson Lee <vlee@freedesktop.org>
    Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.